From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>,
"Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] crypto/scheduler: fix multicore scheduler reordering
Date: Wed, 19 Jul 2017 14:36:04 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBDF77E@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <96dc8c1e-b5a7-2de7-93db-4b53d7d04d5f@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty
> Sent: Wednesday, July 19, 2017 3:03 PM
> To: Rybalchenko, Kirill <kirill.rybalchenko@intel.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] crypto/scheduler: fix multicore
> scheduler reordering
>
> On 18/07/2017 11:35 AM, Kirill Rybalchenko wrote:
> > Operations can be dequeued from the reordering ring only after they
> > were dequeued from the crypto pmd with
> rte_cryptodev_dequeue_burst()
> > function. It is not correct to dequeue them when status just changed
> > from RTE_CRYPTO_OP_STATUS_NOT_PROCESSED to any other value, as
> the
> > operations still can be processed by crypto pmd internally.
> > Now multicore scheduler workers mark status of all dequeued from
> > crypto pmd operations with CRYPTO_OP_STATUS_BIT_COMPLETE bit set.
> > Scheduler will dequeue crypto operations from reordering ring only
> > when this status bit is set. Prior to put this operation to output
> > buffer, scheduler clears this bit, so the application gets unmodified
> > status from crypto pmd.
> >
> > Fixes: 4c07e0552f0a ("crypto/scheduler: add multicore scheduling
> > mode")
> >
> > Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> > ---
> ...
> >
> Acked-by: Declan Doherty <declan.doherty@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
prev parent reply other threads:[~2017-07-19 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 10:35 Kirill Rybalchenko
2017-07-19 14:03 ` Declan Doherty
2017-07-19 14:36 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBDF77E@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=kirill.rybalchenko@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).