From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: performance improvements
Date: Mon, 14 Aug 2017 14:17:43 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBF84D9@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20170728110738.28922-3-akhil.goyal@nxp.com>
Hi Akhil,
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Friday, July 28, 2017 12:08 PM
> To: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> hemant.agrawal@nxp.com; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH] crypto/openssl: performance improvements
>
> key and algo are added in the openssl ctx during session initialization
> instead of adding it for each packet.
>
> Also in case of HMAC the openssl APIs HMAC_XXX give better performance
> for all HMAC cases.
>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
Thanks for the patch, nice optimization!
Could you split this into two patches, as you are doing two different things here?
One for the first sentence and another one for the second sentence.
Also, as you do that, could you rename the title to be more explicit?
Like: crypto/openssl: initialize cipher key at session init
Finally, I was looking at GCM, and I think it could benefit from this.
I will send a separate patch for it, unless you want to integrate it in this patchset yourself.
Thanks,
Pablo
next prev parent reply other threads:[~2017-08-14 14:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 11:07 [dpdk-dev] [PATCH] config: add openssl in arm64-dpaa2-linuxapp-gcc Akhil Goyal
2017-07-28 11:07 ` [dpdk-dev] [PATCH] crypto/openssl: add openssl path for cross compile Akhil Goyal
2017-08-29 7:02 ` [dpdk-dev] [PATCH v2] " Akhil Goyal
2017-09-05 8:22 ` De Lara Guarch, Pablo
2017-09-05 8:37 ` Akhil Goyal
2017-09-05 9:02 ` [dpdk-dev] [PATCH v3] " Akhil Goyal
2017-09-06 9:26 ` De Lara Guarch, Pablo
2017-09-06 10:15 ` De Lara Guarch, Pablo
2017-10-12 13:06 ` Thomas Monjalon
2017-10-12 13:31 ` Hemant Agrawal
2017-10-12 13:34 ` Thomas Monjalon
2017-07-28 11:07 ` [dpdk-dev] [PATCH] crypto/openssl: performance improvements Akhil Goyal
2017-07-28 11:58 ` De Lara Guarch, Pablo
2017-07-28 12:02 ` Akhil Goyal
2017-07-28 12:07 ` De Lara Guarch, Pablo
2017-08-14 14:17 ` De Lara Guarch, Pablo [this message]
2017-08-15 6:44 ` Akhil Goyal
2017-08-15 7:26 ` De Lara Guarch, Pablo
2017-08-16 7:03 ` Akhil Goyal
2017-08-29 6:58 ` [dpdk-dev] [PATCH v2 1/2] crypto/openssl: replace evp APIs with HMAC APIs Akhil Goyal
2017-08-29 6:58 ` [dpdk-dev] [PATCH v2 2/2] crypto/openssl: performance improvements Akhil Goyal
2017-09-04 15:39 ` De Lara Guarch, Pablo
2017-09-05 5:57 ` [dpdk-dev] [PATCH v3 1/2] crypto/openssl: replace evp APIs with HMAC APIs Akhil Goyal
2017-09-05 5:57 ` [dpdk-dev] [PATCH v3 2/2] crypto/openssl: key and algo updated during session init Akhil Goyal
2017-09-06 10:24 ` De Lara Guarch, Pablo
2017-09-04 15:38 ` [dpdk-dev] [PATCH v2 1/2] crypto/openssl: replace evp APIs with HMAC APIs De Lara Guarch, Pablo
2017-09-08 14:03 ` De Lara Guarch, Pablo
2017-09-11 8:41 ` Akhil Goyal
2017-09-20 9:56 ` Akhil Goyal
2017-09-04 14:48 ` [dpdk-dev] [PATCH] config: add openssl in arm64-dpaa2-linuxapp-gcc De Lara Guarch, Pablo
2017-09-05 5:58 ` Akhil Goyal
2017-09-06 10:25 ` De Lara Guarch, Pablo
2017-10-12 13:01 ` Thomas Monjalon
2017-10-12 13:32 ` Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBF84D9@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).