DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	mstolarchuk <mike.stolarchuk@bigswitch.com>
Subject: Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key
Date: Thu, 19 Oct 2017 08:10:22 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC366FD@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <4317181.EN77ZZiejQ@xps>



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, October 17, 2017 2:59 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch,
> Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; mstolarchuk <mike.stolarchuk@bigswitch.com>
> Subject: Re: [dpdk-dev] [PATCH 1/7] Use an accessor for rte_hash_key
> 
> 18/08/2017 22:09, mstolarchuk:
> > Improves consistency, allows identifcation of use-sites
> >
> > Signed-off-by: mstolarchuk <mike.stolarchuk@bigswitch.com>
> 
> Any comment on this patch and others from the same author?

Hi,

Two of the patches submitted are actually the same, although they have a different enumeration.
The patches look like they were part of two different patchsets, so it doesn't look right.
Also, patch 6/6 is not applicable anymore, as a similar fix was sent previously.

Mike, could you send another patchset, that is rebased on top of the latest code?

Thanks,
Pablo

  reply	other threads:[~2017-10-19  8:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 20:09 mstolarchuk
2017-10-17 13:59 ` Thomas Monjalon
2017-10-19  8:10   ` De Lara Guarch, Pablo [this message]
2017-10-27 15:00     ` Mike Stolarchuk
2017-10-27 15:31       ` De Lara Guarch, Pablo
2019-03-01 17:15         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CC366FD@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=mike.stolarchuk@bigswitch.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).