From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 00/14] Move PCI away from the EAL
Date: Mon, 23 Oct 2017 08:44:31 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC39693@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20171011143213.GF31685@bidouze.vm.6wind.com>
Hi Gaetan,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gaëtan Rivet
> Sent: Wednesday, October 11, 2017 3:32 PM
> To: Doherty, Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 00/14] Move PCI away from the EAL
>
> On Wed, Oct 11, 2017 at 03:19:31PM +0100, Doherty, Declan wrote:
> > On 18/09/2017 10:31 AM, Gaetan Rivet wrote:
> > >Hi all,
> > >
> > >Here is a new version of the PCI bus move out of the EAL.
> > >
> > >The EAL PCI implementation is divided in two parts:
> > >
> > > - librte_pci: library offering helpers to handle PCI objects
> > > - librte_bus_pci: bus driver for PCI devices
> > >
> > >This allows other libraries / tools to use PCI elements (location,
> > >mappings, parsing operations, etc) without forcing a dependency on a
> bus driver.
> > >
> > >The latter should not have to export helpers that others might need.
> > >It is focused on defining the rte_pci_device, rte_pci_driver objects
> > >and their handling.
> > >
> > >The cryptodev library has hard dependencies on rte_pci_devices (used
> > >by generic probe function). Other similar libs (ether and eventdev)
> > >avoided the issue by inlining such functions and expecting users to
> > >include the relevant headers once the PCI bus has already been built.
> > >
> > >@Declan:
> > >I proposed a solution that would avoid inlining those functions,
> > >which does not feel right. Let me know what you think of it or if you
> > >think of a better solution. I think it would be best to have
> > >cryptodev completely independent from PCI / vdev as far as the lib in
> > >concerned (the vdev bus will move as well).
> > >
> >
> >
> > Hey Gaetan, apologies for the delay in getting back to you on this, I
> > had been looking at this but got sidelined onto other issues before
> > usersapce and I'm only getting back to it now. I think that while your
> > solution works it just highlights the dependency which probably
> > shouldn't be there between the cryptodev library and PCI devices. I've
> > had a look, and the functions in the cryptodev which you moved don't
> > really provide that much useful functionality. I done some testing and
> > completely removed them and just update the QAT PMD which is the only
> > crypto PMD which was using them and it seems much cleaner to me. I'll
> > push a patch for this change later today and it will allow you to drop
> > the patch "cryptodev: move PCI specific helpers to drivers/crypto" from
> this set.
> >
> > Regards
> > Declan
> >
> >
> >
>
> Hi Declan,
>
> All right, seems good from my PoV. I will rebase onto your patch once it is
> sent.
>
Could you take a look at Declan's patchset and tell him what you think?
http://dpdk.org/ml/archives/dev/2017-October/079827.html
It might be a bit late, but if we think it is a better approach for cryptodev,
we could avoid creating a new PCI folder under drivers/crypto.
Thanks!
Pablo
next prev parent reply other threads:[~2017-10-23 8:44 UTC|newest]
Thread overview: 156+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 9:04 [dpdk-dev] [PATCH 00/13] " Gaetan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 01/13] eal: expose rte_eal_using_phys_addrs Gaetan Rivet
2017-09-04 13:24 ` Burakov, Anatoly
2017-08-25 9:04 ` [dpdk-dev] [PATCH 02/13] ethdev: remove useless PCI dependency Gaetan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 03/13] bus: properly include rte_debug Gaetan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 04/13] eal: remove references to PCI Gaetan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 05/13] pci: introduce PCI lib and bus Gaetan Rivet
2017-08-25 9:31 ` Luca Boccassi
2017-08-25 9:34 ` Gaëtan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 06/13] pci: avoid inlining functions Gaetan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 07/13] pci: avoid over-complicated macro Gaetan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 08/13] pci: deprecate misnamed functions Gaetan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 09/13] lib: include rte_bus_pci Gaetan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 10/13] drivers: " Gaetan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 11/13] test: " Gaetan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 12/13] app/testpmd: " Gaetan Rivet
2017-08-25 9:04 ` [dpdk-dev] [PATCH 13/13] cryptodev: move PCI specific helpers to drivers/crypto Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 00/14] Move PCI away from the EAL Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 01/14] eal: expose rte_eal_using_phys_addrs Gaetan Rivet
2017-09-18 10:47 ` Shreyansh Jain
2017-09-18 11:37 ` Gaëtan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 02/14] ethdev: remove useless PCI dependency Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 03/14] bus: properly include rte_debug Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 04/14] eal: remove references to PCI Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 05/14] pci: introduce PCI lib and bus Gaetan Rivet
2017-09-18 11:53 ` Shreyansh Jain
2017-09-18 11:51 ` Gaëtan Rivet
2017-09-18 12:18 ` Shreyansh Jain
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 06/14] lib: include rte_bus_pci Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 07/14] drivers: " Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 08/14] test: " Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 09/14] app/testpmd: " Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 10/14] cryptodev: move PCI specific helpers to drivers/crypto Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 11/14] pci: avoid inlining functions Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 12/14] pci: avoid over-complicated macro Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 13/14] pci: deprecate misnamed functions Gaetan Rivet
2017-09-18 9:31 ` [dpdk-dev] [PATCH v2 14/14] doc: add notes on EAL PCI API update Gaetan Rivet
2017-09-18 11:22 ` Mcnamara, John
2017-09-25 15:23 ` [dpdk-dev] [PATCH v3 00/13] Move PCI away from the EAL Gaetan Rivet
2017-09-25 15:23 ` [dpdk-dev] [PATCH v3 01/13] eal: expose rte_eal_using_phys_addrs Gaetan Rivet
2017-09-25 15:23 ` [dpdk-dev] [PATCH v3 02/13] ethdev: remove useless PCI dependency Gaetan Rivet
2017-09-25 15:24 ` [dpdk-dev] [PATCH v3 03/13] bus: properly include rte_debug Gaetan Rivet
2017-09-25 15:24 ` [dpdk-dev] [PATCH v3 04/13] pci: introduce PCI lib and bus Gaetan Rivet
2017-09-25 15:24 ` [dpdk-dev] [PATCH v3 05/13] lib: include rte_bus_pci Gaetan Rivet
2017-09-25 15:24 ` [dpdk-dev] [PATCH v3 06/13] drivers: " Gaetan Rivet
2017-09-25 15:24 ` [dpdk-dev] [PATCH v3 07/13] test: " Gaetan Rivet
2017-09-25 15:24 ` [dpdk-dev] [PATCH v3 08/13] app/testpmd: " Gaetan Rivet
2017-09-25 15:24 ` [dpdk-dev] [PATCH v3 09/13] cryptodev: move PCI specific helpers to drivers/crypto Gaetan Rivet
2017-09-25 15:24 ` [dpdk-dev] [PATCH v3 10/13] pci: avoid inlining functions Gaetan Rivet
2017-09-25 15:24 ` [dpdk-dev] [PATCH v3 11/13] pci: avoid over-complicated macro Gaetan Rivet
2017-09-25 15:24 ` [dpdk-dev] [PATCH v3 12/13] pci: deprecate misnamed functions Gaetan Rivet
2017-09-25 15:24 ` [dpdk-dev] [PATCH v3 13/13] doc: add notes on EAL PCI API update Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 00/16] Move PCI away from the EAL Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 01/16] eal: include debug header in bus source Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 02/16] ethdev: remove useless PCI dependency Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 03/16] pci: introduce PCI lib and bus Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 04/16] lib: include PCI bus header Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 05/16] drivers: " Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 06/16] test: " Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 07/16] app/testpmd: " Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 08/16] cryptodev: move PCI specific helpers to drivers/crypto Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 09/16] net/bonding: use local prefix for local function Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 10/16] pci: avoid inlining functions Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 11/16] pci: avoid over-complicated macro Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 12/16] pci: deprecate misnamed functions Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 13/16] pci: introduce PCI address parsing function Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 14/16] pci: make specialized parsing functions private Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 15/16] bus/pci: use new PCI addr parsing function Gaetan Rivet
2017-10-12 8:17 ` [dpdk-dev] [PATCH v4 16/16] doc: add notes on EAL PCI API update Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 00/20] Move PCI away from the EAL Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 01/20] eal: include debug header in bus source Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 02/20] ethdev: remove useless PCI dependency Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 03/20] pci: introduce PCI lib and bus Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 04/20] lib: include PCI bus header Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 05/20] drivers: " Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 06/20] test: " Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 07/20] app/testpmd: " Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 08/20] cryptodev: move PCI specific helpers to drivers/crypto Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 09/20] net/bonding: use local prefix for local function Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 10/20] pci: avoid inlining functions Gaetan Rivet
2017-10-17 18:20 ` Aaron Conole
2017-10-18 8:54 ` Gaëtan Rivet
2017-10-18 14:30 ` Aaron Conole
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 11/20] pci: avoid over-complicated macro Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 12/20] pci: deprecate misnamed functions Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 13/20] pci: introduce PCI address parsing function Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 14/20] pci: make specialized parsing functions private Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 15/20] bus/pci: use new PCI addr parsing function Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 16/20] bus/pci: do not expose private functions Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 17/20] bus/pci: do not expose PCI match function Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 18/20] bus/pci: do not expose IOVA mode getter Gaetan Rivet
2017-10-12 10:54 ` Gaëtan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 19/20] doc: add notes on EAL PCI API update Gaetan Rivet
2017-10-12 10:45 ` [dpdk-dev] [PATCH v5 20/20] bus: rename scan policy as probe policy Gaetan Rivet
2017-10-12 10:55 ` Gaëtan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 00/25] Move PCI away from the EAL Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 01/25] ethdev: remove useless PCI dependency Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 02/25] eal: include debug header in bus source Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 03/25] eal: include stdint in private header Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 04/25] eal: include common header Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 05/25] eal: expose rte_eal_using_phys_addrs Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 06/25] eal: expose internal config elements Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 07/25] eal: expose vfio symbols Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 08/25] vfio: remove useless PCI headers and add vfio one Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 09/25] vfio: check PCI dependency from within PCI code Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 10/25] vfio: move PCI-related functions out of vfio header Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 11/25] pci: avoid inlining functions Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 12/25] pci: avoid over-complicated macro Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 13/25] pci: deprecate misnamed functions Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 14/25] pci: introduce PCI address parsing function Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 15/25] pci: make specialized parsing functions private Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 16/25] pci: use new PCI addr comparison function Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 17/25] pci: use new PCI addr parsing function Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 18/25] pci: do not expose private functions Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 19/25] pci: do not expose PCI match function Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 20/25] pci: do not expose IOVA mode getter Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 21/25] pci: use EAL exposed configuration Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 22/25] net/bonding: use local prefix for local function Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 23/25] pci: introduce PCI lib and bus Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 24/25] doc: add notes on EAL PCI API update Gaetan Rivet
2017-10-25 22:38 ` [dpdk-dev] [PATCH v7 25/25] maintainers: claim maintainership of PCI lib Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 00/25] Move PCI away from the EAL Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 01/25] ethdev: remove useless PCI dependency Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 02/25] eal: include debug header in bus source Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 03/25] eal: include stdint in private header Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 04/25] eal: include common header Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 05/25] eal: expose rte_eal_using_phys_addrs Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 06/25] eal: expose internal config elements Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 07/25] eal: expose vfio symbols Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 08/25] vfio: remove useless PCI headers Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 09/25] vfio: check PCI dependency from within PCI code Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 10/25] vfio: move PCI-related symbols out of vfio header Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 11/25] pci: avoid inlining functions Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 12/25] pci: avoid over-complicated macro Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 13/25] pci: deprecate misnamed functions Gaetan Rivet
2017-10-26 10:05 ` [dpdk-dev] [PATCH v8 14/25] pci: introduce PCI address parsing function Gaetan Rivet
2017-10-26 10:06 ` [dpdk-dev] [PATCH v8 15/25] pci: make specialized parsing functions private Gaetan Rivet
2017-10-26 10:06 ` [dpdk-dev] [PATCH v8 16/25] pci: use new PCI addr comparison function Gaetan Rivet
2017-10-26 10:06 ` [dpdk-dev] [PATCH v8 17/25] pci: use new PCI addr parsing function Gaetan Rivet
2017-10-26 10:06 ` [dpdk-dev] [PATCH v8 18/25] pci: do not expose private functions Gaetan Rivet
2017-10-26 10:06 ` [dpdk-dev] [PATCH v8 19/25] pci: do not expose PCI match function Gaetan Rivet
2017-10-26 10:06 ` [dpdk-dev] [PATCH v8 20/25] pci: do not expose IOVA mode getter Gaetan Rivet
2017-10-26 10:06 ` [dpdk-dev] [PATCH v8 21/25] pci: use EAL exposed configuration Gaetan Rivet
2017-10-26 10:06 ` [dpdk-dev] [PATCH v8 22/25] net/bonding: use local prefix for local function Gaetan Rivet
2017-10-26 10:06 ` [dpdk-dev] [PATCH v8 23/25] pci: introduce PCI lib and bus Gaetan Rivet
2017-10-26 15:56 ` Thomas Monjalon
2017-10-26 17:44 ` Thomas Monjalon
2017-10-26 10:06 ` [dpdk-dev] [PATCH v8 24/25] doc: add notes on EAL PCI API update Gaetan Rivet
2017-10-26 10:06 ` [dpdk-dev] [PATCH v8 25/25] maintainers: claim maintainership of PCI lib Gaetan Rivet
2017-10-26 21:23 ` [dpdk-dev] [PATCH v8 00/25] Move PCI away from the EAL Thomas Monjalon
2017-10-29 16:47 ` Andrew Rybchenko
2017-10-30 5:16 ` Gaëtan Rivet
2017-10-11 14:19 ` [dpdk-dev] [PATCH v2 00/14] " Doherty, Declan
2017-10-11 14:32 ` Gaëtan Rivet
2017-10-23 8:44 ` De Lara Guarch, Pablo [this message]
2017-10-23 8:49 ` Gaëtan Rivet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CC39693@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).