From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
"Nicolau, Radu" <radu.nicolau@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add cryptodev mask option
Date: Wed, 10 Jan 2018 16:30:50 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC6D174@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <12ddac44-3c50-d4ad-e179-1e4e8b8a33e5@nxp.com>
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, January 10, 2018 2:22 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; Gonzalez Monroy, Sergio
> <sergio.gonzalez.monroy@intel.com>; Nicolau, Radu
> <radu.nicolau@intel.com>
> Subject: Re: [PATCH] examples/ipsec-secgw: add cryptodev mask option
>
> Hi Pablo,
> On 1/10/2018 6:17 PM, De Lara Guarch, Pablo wrote:
> > Hi Akhil,
> >
> >> -----Original Message-----
> >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> >> Sent: Thursday, December 14, 2017 6:52 AM
> >> To: dev@dpdk.org
> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> >> hemant.agrawal@nxp.com; Gonzalez Monroy, Sergio
> >> <sergio.gonzalez.monroy@intel.com>; Nicolau, Radu
> >> <radu.nicolau@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> >> Subject: [PATCH] examples/ipsec-secgw: add cryptodev mask option
> >>
> >> Previously, ipsec-secgw application did not give user the flexibility
> >> to decide which crypto device(s) will be used.
> >>
> >> In this patch, a new cryptodev_mask option is added to the application.
> >> Same as portmask, the cryptodev_mask avails the user to mask out the
> >> unwanted crypto devices in the system.
> >>
> >> This patch is similar to the support added in l2fwd-crypto
> >> (d2797f51cc63: examples/l2fwd-crypto: add cryptodev mask option)
> >>
> >> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> >> ---
> >
> > ...
> >
> > Not sure if you should change the order of the crypto devices that was
> > set previously (starting from the end and not from the beginning).
> Shouldn't we keep it as it was?
> Actually as per the current code base there is no fix order of the devices to
> be available. In bus scan, all(pci,fslmc,vdev) have same priority(110), which
> means whatever is first recognized/linked will come first.
>
> So the assumption that last cdev_id is HW doesn't seem to be correct.
> I just wanted to make the code similar to l2fwd-crypto and the behavior of
> cryptodev_mask similar to what l2fwd-crypto understands.
>
> Please let me know if my understanding is not correct.
Right, actually I am seeing PCI devices first on my system, so clearly the statement below was wrong.
Looks ok to me then :)
Thanks,
Pablo
>
> >
> >> idx = 0;
> >> - /* Start from last cdev id to give HW priority */
> >> - for (cdev_id = rte_cryptodev_count() - 1; cdev_id >= 0; cdev_id--) {
> >> + for (cdev_id = 0; cdev_id < rte_cryptodev_count(); cdev_id++) {
> >> struct rte_cryptodev_info cdev_info;
> >>
> >> + if (check_cryptodev_mask((uint8_t)cdev_id))
> >> + continue;
> >> +
> >> rte_cryptodev_info_get(cdev_id, &cdev_info);
> >>
> >> if (nb_lcore_params > cdev_info.max_nb_queue_pairs)
> >> --
> >> 2.9.3
> >
> > For the rest, I don't have other objections, so apart from the comment
> above:
> >
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >
> >
>
> Thanks,
> Akhil
next prev parent reply other threads:[~2018-01-10 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 6:52 Akhil Goyal
2018-01-10 12:47 ` De Lara Guarch, Pablo
2018-01-10 14:21 ` Akhil Goyal
2018-01-10 16:30 ` De Lara Guarch, Pablo [this message]
2018-01-11 14:25 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CC6D174@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=radu.nicolau@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).