DPDK patches and discussions
 help / color / mirror / Atom feed

From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
	"Varghese, Vipin" <vipin.varghese@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: update multiple instance info for NULL	crypto
Date: Mon, 5 Feb 2018 15:54:42 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CC93598@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1517841119-9277-1-git-send-email-vipin.varghese@intel.com>

Hi Vipin,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Vipin Varghese
> Sent: Monday, February 5, 2018 2:32 PM
> To: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>
> Cc: Mcnamara, John <john.mcnamara@intel.com>; Varghese, Vipin
> <vipin.varghese@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: update multiple instance info for NULL
> crypto
> 
> Add foot note & example to inform user how to use multiple instance.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
>  doc/guides/cryptodevs/null.rst | 20 +++++++++++++++++---
>  1 file changed, 17 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/guides/cryptodevs/null.rst b/doc/guides/cryptodevs/null.rst
> index 03a3ddc..b7072b0 100644
> --- a/doc/guides/cryptodevs/null.rst
> +++ b/doc/guides/cryptodevs/null.rst
> @@ -41,6 +41,11 @@ each mbuf in the burst will be enqueued in an
> internal buffer for collection on  a dequeue call as long as the mbuf has a
> valid rte_mbuf_offload operation with  a valid rte_cryptodev_session or
> rte_crypto_xform chain of operations.
> 
> +.. Note::
> +
> +    In case of multiple instances of NULL cryptos, each instance should be of
> +    unique id.

I would use "NULL crypto PMDs".

> +
>  Features
>  --------
> 
> @@ -91,7 +96,16 @@ The following parameters (all optional) can be
> provided in the previous two call
> 
>  Example:
> 
> -.. code-block:: console
> +Single vdev instance::
> +
> +   ./l2fwd-crypto -l 1 -n 4 \
> +   --vdev="crypto_null,socket_id=0,max_nb_sessions=128" \
> +   -- -p 1 --cdev SW --chain CIPHER_ONLY --cipher_algo "null"
> +
> +Multiple vdev instance::

"instances".

> +
> +   ./l2fwd-crypto -l 1-2 -n 4 \
> +   --vdev="crypto_null_0,socket_id=0,max_nb_sessions=128" \
> +   --vdev="crypto_null_1,socket_id=1,max_nb_sessions=128" \
> +   -- -p 0x3 --cdev SW --chain CIPHER_HASH --cipher_algo null
> + --auth_algo null
> 
> -    ./l2fwd-crypto -l 1 -n 4 --
> vdev="crypto_null,socket_id=0,max_nb_sessions=128" \
> -    -- -p 1 --cdev SW --chain CIPHER_ONLY --cipher_algo "null"
> --
> 1.9.1

This looks good to me, but I think this can be extended to other PMDs, not just NULL crypto.
Could you send another version, changing the other guides (for the SW based drivers)?

Thanks,
Pablo

next prev parent reply	other threads:[~2018-02-05 15:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 14:31 Vipin Varghese
2018-02-05 15:54 ` De Lara Guarch, Pablo [this message]
2018-02-06 13:43 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2018-02-06 16:11   ` [dpdk-dev] [PATCH v3] doc: add info on multiple instance SW crypto Vipin Varghese
2018-02-06 16:23     ` De Lara Guarch, Pablo
2018-02-06 21:22       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CC93598@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).