From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Tomasz Duszynski <tdu@semihalf.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Doherty, Declan" <declan.doherty@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] crypto/mrvl: add MRVL to hash test cases
Date: Wed, 14 Mar 2018 12:03:53 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CCA9592@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20180314102952.GA8527@sh>
> -----Original Message-----
> From: Tomasz Duszynski [mailto:tdu@semihalf.com]
> Sent: Wednesday, March 14, 2018 10:30 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Tomasz Duszynski <tdu@semihalf.com>; dev@dpdk.org; Doherty,
> Declan <declan.doherty@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH] crypto/mrvl: add MRVL to hash test cases
>
> On Wed, Mar 14, 2018 at 10:13:58AM +0000, De Lara Guarch, Pablo wrote:
> > Hi Tomasz,
> >
> > > -----Original Message-----
> > > From: Tomasz Duszynski [mailto:tdu@semihalf.com]
> > > Sent: Thursday, March 8, 2018 1:27 PM
> > > To: dev@dpdk.org
> > > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty,
> > > Declan <declan.doherty@intel.com>; Richardson, Bruce
> > > <bruce.richardson@intel.com>; Tomasz Duszynski
> <tdu@semihalf.com>;
> > > stable@dpdk.org
> > > Subject: Re: [PATCH] crypto/mrvl: add MRVL to hash test cases
> > >
> >
> > This is targetting the crypto tests, so title should be "test/crypto: ... "
>
> Ack.
>
> >
> >
> > > This patch has been here for a while already. Should I respin it?
> > >
> > > On Wed, Feb 28, 2018 at 03:53:53PM +0100, Tomasz Duszynski wrote:
> > > > MRVL Crypto PMD supports most of the hash algorithms covered by
> > > > test suites thus specific bits should be set in pmd_masks.
> > > >
> > > > Otherwise blockcipher authonly test returns success even though no
> > > > real tests have been executed.
> >
> > > >
> > > > Fixes: 84e0ded38ac5 ("test/crypto: add mrvl crypto unit tests")
> > > > Cc: stable@dpdk.org
> >
> > I don't think this is a fix, so I would remove the fixes and CC stable lines.
>
> Why? I think this should have been here since introduction on mrvl/cryto.
> If you take a look at 84e0ded38ac5 there is test called:
> test_authonly_mrvl_all() which runs blockcipher tests with
> BLKCIPHER_AUTHONLY_TYPE flag.
>
> Since MRVL pmd flag was missing from pmd_mask in
> blockcipher_test_case_hash_test_cases table tests were not run. Moreover
> overall_status variable was not touched thus test suite completed without
> errors.
Right, I thought that this patch was just adding the PMD to the hast test cases,
I wasn't looking at it from a fix point of view, but I guess you are right.
Thanks for clarifying.
Pablo
>
> >
> > Thanks,
> > Pablo
> >
> > > >
> > > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> >
>
> --
> - Tomasz Duszyński
next prev parent reply other threads:[~2018-03-14 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 14:53 Tomasz Duszynski
2018-03-08 13:27 ` Tomasz Duszynski
2018-03-13 9:32 ` De Lara Guarch, Pablo
2018-03-14 10:13 ` De Lara Guarch, Pablo
2018-03-14 10:29 ` Tomasz Duszynski
2018-03-14 12:03 ` De Lara Guarch, Pablo [this message]
2018-03-14 13:12 ` [dpdk-stable] [PATCH v2] test/crypto: " Tomasz Duszynski
2018-03-26 8:28 ` De Lara Guarch, Pablo
2018-03-26 8:57 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CCA9592@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tdu@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).