From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Zhoujian (jay)" <jianjay.zhou@huawei.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"Zeng, Xin" <xin.zeng@intel.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
"wangxin (U)" <wangxinxin.wang@huawei.com>,
longpeng <longpeng2@huawei.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/7] crpyto/virtio: add crypto related session structure
Date: Fri, 30 Mar 2018 07:38:21 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CCC27C4@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <B2D15215269B544CADD246097EACE7473AC1BD6C@DGGEMM505-MBS.china.huawei.com>
> -----Original Message-----
> From: Zhoujian (jay) [mailto:jianjay.zhou@huawei.com]
> Sent: Friday, March 30, 2018 3:44 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; thomas@monjalon.net;
> Gonglei (Arei) <arei.gonglei@huawei.com>; Zeng, Xin
> <xin.zeng@intel.com>; Huangweidong (C) <weidong.huang@huawei.com>;
> wangxin (U) <wangxinxin.wang@huawei.com>; longpeng
> <longpeng2@huawei.com>
> Subject: RE: [PATCH v3 2/7] crpyto/virtio: add crypto related session
> structure
>
>
>
> > -----Original Message-----
> > From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com]
> > Sent: Friday, March 30, 2018 6:12 AM
> > To: Zhoujian (jay) <jianjay.zhou@huawei.com>; dev@dpdk.org
> > Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; thomas@monjalon.net;
> > Gonglei
> > (Arei) <arei.gonglei@huawei.com>; Zeng, Xin <xin.zeng@intel.com>;
> > Huangweidong (C) <weidong.huang@huawei.com>; wangxin (U)
> > <wangxinxin.wang@huawei.com>; longpeng <longpeng2@huawei.com>
> > Subject: RE: [PATCH v3 2/7] crpyto/virtio: add crypto related session
> > structure
> >
> >
> >
> > > -----Original Message-----
> > > From: Jay Zhou [mailto:jianjay.zhou@huawei.com]
> > > Sent: Sunday, March 25, 2018 9:34 AM
> > > To: dev@dpdk.org
> > > Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Zhang,
> > > Roy Fan <roy.fan.zhang@intel.com>; thomas@monjalon.net;
> > > arei.gonglei@huawei.com; Zeng, Xin <xin.zeng@intel.com>;
> > > weidong.huang@huawei.com; wangxinxin.wang@huawei.com;
> > > longpeng2@huawei.com; jianjay.zhou@huawei.com
> > > Subject: [PATCH v3 2/7] crpyto/virtio: add crypto related session
> > > structure
> >
> > Typo in title.
>
> Will fix.
>
> >
> > >
> > > This structure will be used in the following patches, especially at
> > > creating and destroying crypto sessions.
> > >
> > > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > > ---
> > > drivers/crypto/virtio/virtio_crypto_algs.h | 27
> > > +++++++++++++++++++++++++++
> > > 1 file changed, 27 insertions(+)
> > > create mode 100644 drivers/crypto/virtio/virtio_crypto_algs.h
> > >
> > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.h
> > > b/drivers/crypto/virtio/virtio_crypto_algs.h
> > > new file mode 100644
> > > index 0000000..5f1e9df
> > > --- /dev/null
> > > +++ b/drivers/crypto/virtio/virtio_crypto_algs.h
> > > @@ -0,0 +1,27 @@
> > > +/* SPDX-License-Identifier: BSD-3-Clause
> > > + * Copyright(c) 2018 HUAWEI TECHNOLOGIES CO., LTD.
> > > + */
> > > +
> > > +#ifndef _VIRTIO_CRYPTO_ALGS_H_
> > > +#define _VIRTIO_CRYPTO_ALGS_H_
> > > +
> > > +#include <rte_memory.h>
> > > +#include <linux/virtio_crypto.h>
> > > +
> > > +struct virtio_crypto_session {
> > > + uint64_t session_id;
> >
> > Probably a uint32_t here is enough.
>
> Consider the type of session_id in the struct virtio_crypto_op_header of
> linux kernel and QEMU side is uint64_t, could we just keep it as uint64_t
> for consistency?
Fair enough.
Pablo
>
> Regards,
> Jay
next prev parent reply other threads:[~2018-03-30 7:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 8:33 [dpdk-dev] [PATCH v3 0/7] crypto: add virtio poll mode driver Jay Zhou
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 1/7] crypto/virtio: add virtio related fundamental functions Jay Zhou
2018-03-26 5:16 ` Zhang, Roy Fan
2018-03-29 16:06 ` De Lara Guarch, Pablo
2018-03-30 2:28 ` Zhoujian (jay)
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 2/7] crpyto/virtio: add crypto related session structure Jay Zhou
2018-03-26 5:20 ` Zhang, Roy Fan
2018-03-29 22:12 ` De Lara Guarch, Pablo
2018-03-30 2:43 ` Zhoujian (jay)
2018-03-30 7:38 ` De Lara Guarch, Pablo [this message]
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 3/7] cryptodev/virtio: core code of crypto devices Jay Zhou
2018-03-26 5:17 ` Zhang, Roy Fan
2018-03-29 22:28 ` De Lara Guarch, Pablo
2018-03-30 3:02 ` Zhoujian (jay)
2018-03-30 7:39 ` De Lara Guarch, Pablo
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 4/7] crypto/virtio: add makefile Jay Zhou
2018-03-26 5:17 ` Zhang, Roy Fan
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 5/7] cryptodev: add document for virtio crypto PMD Jay Zhou
2018-03-26 5:18 ` Zhang, Roy Fan
2018-03-29 22:36 ` De Lara Guarch, Pablo
2018-03-30 6:36 ` Zhoujian (jay)
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 6/7] cryptodev: add function tests " Jay Zhou
2018-03-26 5:18 ` Zhang, Roy Fan
2018-03-29 22:31 ` De Lara Guarch, Pablo
2018-03-25 8:33 ` [dpdk-dev] [PATCH v3 7/7] MAINTAINERS: add myself as virtio crypto PMD maintainer Jay Zhou
2018-03-26 8:04 ` Zhang, Roy Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CCC27C4@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=arei.gonglei@huawei.com \
--cc=dev@dpdk.org \
--cc=jianjay.zhou@huawei.com \
--cc=longpeng2@huawei.com \
--cc=roy.fan.zhang@intel.com \
--cc=thomas@monjalon.net \
--cc=wangxinxin.wang@huawei.com \
--cc=weidong.huang@huawei.com \
--cc=xin.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).