From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Pascal Mazon <pascal.mazon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/tap: fix icc build
Date: Tue, 24 Apr 2018 13:21:06 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CCDBE05@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20180312193134.219899-1-ferruh.yigit@intel.com>
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Monday, March 12, 2018 7:32 PM
> To: Pascal Mazon <pascal.mazon@6wind.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org
> Subject: [dpdk-stable] [PATCH] net/tap: fix icc build
>
> build error:
> .../dpdk/drivers/net/tap/rte_eth_tap.c(598):
> error #279: controlling expression is constant
> RTE_ASSERT(!"unsupported request type: must not happen");
>
> Although RTE_ASSERT helps debugging this issue when assert enabled, constant
> expression in assert means this path can be taken during runtime and there is no
> protection against it when assert is disabled.
>
> Adding error log and error return back, replacing RTE_ASSERT.
>
> Fixes: 7748a4b44196 ("net/tap: add debug messages")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
next prev parent reply other threads:[~2018-04-24 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 19:31 Ferruh Yigit
2018-04-24 13:21 ` De Lara Guarch, Pablo [this message]
2018-04-24 17:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CCDBE05@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pascal.mazon@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).