From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Tomasz Duszynski <tdu@semihalf.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "dima@marvell.com" <dima@marvell.com>,
Natalie Samsonov <nsamsono@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2] crypto/mrvl: rename PMD to mvsam
Date: Mon, 7 May 2018 14:19:42 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CD03434@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1524813326-31233-1-git-send-email-tdu@semihalf.com>
> -----Original Message-----
> From: Tomasz Duszynski [mailto:tdu@semihalf.com]
> Sent: Friday, April 27, 2018 8:15 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> dima@marvell.com; Tomasz Duszynski <tdu@semihalf.com>; Natalie Samsonov
> <nsamsono@marvell.com>
> Subject: [PATCH v2] crypto/mrvl: rename PMD to mvsam
>
> Picking a company stock ticker for a PMD name might not be a best approach in
> a long run since name is too generic.
>
> This patch addresses that and renames mrvl to mvsam.
>
> Signed-off-by: Natalie Samsonov <nsamsono@marvell.com>
> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> ---
...
> --- a/test/test/test_cryptodev.h
> +++ b/test/test/test_cryptodev.h
> @@ -61,7 +61,7 @@
> #define CRYPTODEV_NAME_DPAA_SEC_PMD crypto_dpaa_sec
> #define CRYPTODEV_NAME_DPAA2_SEC_PMD crypto_dpaa2_sec
> #define CRYPTODEV_NAME_SCHEDULER_PMD crypto_scheduler
> -#define CRYPTODEV_NAME_MRVL_PMD crypto_mrvl
> +#define CRYPTODEV_NAME_MRVL_PMD crypto_mvsam
I think it would be better if you modify the macro names in the test app, to be MVSAM.
> #define CRYPTODEV_NAME_CCP_PMD crypto_ccp
> #define CRYPTODEV_NAME_VIRTIO_PMD crypto_virtio
>
> --
> 2.7.4
next prev parent reply other threads:[~2018-05-07 14:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 17:22 [dpdk-dev] [PATCH] " Tomasz Duszynski
2018-04-26 17:38 ` Stephen Hemminger
2018-04-27 5:31 ` Tomasz Duszynski
2018-04-26 18:48 ` Thomas Monjalon
2018-04-27 5:18 ` Tomasz Duszynski
2018-04-27 7:15 ` [dpdk-dev] [PATCH v2] " Tomasz Duszynski
2018-05-07 14:19 ` De Lara Guarch, Pablo [this message]
2018-05-08 6:13 ` Tomasz Duszynski
2018-05-08 8:14 ` [dpdk-dev] [PATCH v3] " Tomasz Duszynski
2018-05-08 8:57 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CD03434@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=dima@marvell.com \
--cc=nsamsono@marvell.com \
--cc=tdu@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).