From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>,
"Nicolau, Radu" <radu.nicolau@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] examples/ipsec-secgw: limit inflight packets count
Date: Wed, 9 May 2018 15:02:01 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CD0567E@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <01c2959d-1214-3309-b943-d08d4c20d5e5@nxp.com>
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, May 9, 2018 1:02 PM
> To: Nicolau, Radu <radu.nicolau@intel.com>; dev@dpdk.org
> Cc: akhil.goyal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: limit inflight packets
> count
>
> On 5/9/2018 2:28 PM, Radu Nicolau wrote:
> > Revert previous patch that introduce a performance degradation in
> > certain scenarios and add a configurable limit for number inflight
> > packets.
> >
> > Revert
> > commit 84d4b5e4ec48 ("examples/ipsec-secgw: improve IPsec dequeue
> > logic")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> > ---
> > v3: updated enqueue size trim computation
> >
> > examples/ipsec-secgw/ipsec.c | 32 +++++++++++++++-----------------
> > examples/ipsec-secgw/ipsec.h | 1 +
> > 2 files changed, 16 insertions(+), 17 deletions(-)
> >
> > diff --git a/examples/ipsec-secgw/ipsec.c
> > b/examples/ipsec-secgw/ipsec.c index ee24973..1929752 100644
> > --- a/examples/ipsec-secgw/ipsec.c
> > +++ b/examples/ipsec-secgw/ipsec.c
> > @@ -348,13 +348,19 @@ create_session(struct ipsec_ctx *ipsec_ctx,
> > struct ipsec_sa *sa) static inline void enqueue_cop(struct cdev_qp
> > *cqp, struct rte_crypto_op *cop) {
> > - int32_t ret, i;
> > + int32_t ret = 0, i;
> >
> > cqp->buf[cqp->len++] = cop;
> >
> > if (cqp->len == MAX_PKT_BURST) {
> > - ret = rte_cryptodev_enqueue_burst(cqp->id, cqp->qp,
> > - cqp->buf, cqp->len);
> > + int enq_size = cqp->len;
> > + if ((cqp->in_flight + enq_size) >= MAX_INFLIGHT)
>
> This should be ((cqp->in_flight + enq_size) > MAX_INFLIGHT). there Will be one
> extra operation in case it is equal.
>
> Otherwise,
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto, with change requested.
Thanks,
Pablo
prev parent reply other threads:[~2018-05-09 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 11:07 [dpdk-stable] [PATCH] " Radu Nicolau
2018-05-09 8:56 ` [dpdk-stable] [PATCH v2] " Radu Nicolau
2018-05-09 8:58 ` [dpdk-stable] [PATCH v3] " Radu Nicolau
2018-05-09 12:02 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal
2018-05-09 15:02 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CD0567E@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).