From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Andy Green <andy@warmcat.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4 10/18] net/qede: solve broken strncpy
Date: Fri, 11 May 2018 10:47:29 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CD089E9@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <152600316606.53146.14953519058439248573.stgit@localhost.localdomain>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
> Sent: Friday, May 11, 2018 2:46 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v4 10/18] net/qede: solve broken strncpy
>
> /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c: In function
> ‘qed_slowpath_start’:
> /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c:307:3:
> error: ‘strncpy’ output may be truncated copying 12 bytes from a string of length
> 127 [-Werror=stringop-truncation]
> strncpy((char *)drv_version.name, (const char *)params->name,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> MCP_DRV_VER_STR_SIZE - 4);
> ~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Andy Green <andy@warmcat.com>
> ---
> drivers/net/qede/qede_main.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
> index 2333ca073..fcfc32d0d 100644
> --- a/drivers/net/qede/qede_main.c
> +++ b/drivers/net/qede/qede_main.c
> @@ -9,6 +9,7 @@
> #include <limits.h>
> #include <time.h>
> #include <rte_alarm.h>
> +#include <rte_string_fns.h>
>
> #include "qede_ethdev.h"
>
> @@ -303,9 +304,9 @@ static int qed_slowpath_start(struct ecore_dev *edev,
> drv_version.version = (params->drv_major << 24) |
> (params->drv_minor << 16) |
> (params->drv_rev << 8) | (params->drv_eng);
> - /* TBD: strlcpy() */
> - strncpy((char *)drv_version.name, (const char *)params->name,
> - MCP_DRV_VER_STR_SIZE - 4);
> + strlcpy((char *)drv_version.name, (const char *)params->name,
> + sizeof(drv_version.name));
> + drv_version.name[sizeof(drv_version.name) - 1] = '\0';
Strlcpy already terminates the buffer with NULL character, so this last line is not needed.
Also, missing fix line and CC stable
Fixes: 86a2265e59d7 ("qede: add SRIOV support")
Cc: stable@dpdk.org
next prev parent reply other threads:[~2018-05-11 10:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <152600304856.53146.9681482138854493833.stgit@localhost.localdomain>
[not found] ` <152600313083.53146.365116365602153188.stgit@localhost.localdomain>
2018-05-11 8:17 ` [dpdk-stable] [dpdk-dev] [PATCH v4 03/18] bus/pci: replace strncpy dangerous code De Lara Guarch, Pablo
[not found] ` <152600313586.53146.7523419645550338762.stgit@localhost.localdomain>
2018-05-11 8:26 ` [dpdk-stable] [dpdk-dev] [PATCH v4 04/18] bus/dpaa: solve inconsistent struct alignment De Lara Guarch, Pablo
[not found] ` <152600312580.53146.1090136345409468008.stgit@localhost.localdomain>
2018-05-11 8:58 ` [dpdk-stable] [dpdk-dev] [PATCH v4 02/18] net/nfp: solve buffer overflow De Lara Guarch, Pablo
2018-05-11 10:13 ` De Lara Guarch, Pablo
[not found] ` <152600315600.53146.7909626180486080315.stgit@localhost.localdomain>
2018-05-11 10:36 ` [dpdk-stable] [dpdk-dev] [PATCH v4 08/18] net/nfp: don't memcpy out of source range De Lara Guarch, Pablo
[not found] ` <152600316103.53146.10955338688055072616.stgit@localhost.localdomain>
2018-05-11 10:43 ` [dpdk-stable] [dpdk-dev] [PATCH v4 09/18] net/qede: strncpy length constant and NUL De Lara Guarch, Pablo
2018-05-11 10:48 ` Andy Green
2018-05-11 12:48 ` De Lara Guarch, Pablo
2018-05-11 13:38 ` Andy Green
2018-05-11 15:14 ` De Lara Guarch, Pablo
2018-05-11 17:13 ` Shaikh, Shahed
[not found] ` <152600316606.53146.14953519058439248573.stgit@localhost.localdomain>
2018-05-11 10:47 ` De Lara Guarch, Pablo [this message]
[not found] ` <152600317109.53146.6555330710274289069.stgit@localhost.localdomain>
2018-05-11 10:51 ` [dpdk-stable] [dpdk-dev] [PATCH v4 11/18] net/sfc: correct strncpy length De Lara Guarch, Pablo
2018-05-12 1:21 ` Andy Green
[not found] ` <152600317613.53146.6276891139126316271.stgit@localhost.localdomain>
2018-05-11 10:55 ` [dpdk-stable] [dpdk-dev] [PATCH v4 12/18] net/sfc: solve strncpy size and NUL De Lara Guarch, Pablo
2018-05-12 1:24 ` Andy Green
[not found] ` <152600318620.53146.6364478443735658822.stgit@localhost.localdomain>
2018-05-11 10:58 ` [dpdk-stable] [dpdk-dev] [PATCH v4 14/18] net/vdev_netvsc: 3 x strncpy misuse De Lara Guarch, Pablo
[not found] ` <152600319626.53146.13225564187658388686.stgit@localhost.localdomain>
2018-05-11 12:26 ` [dpdk-stable] [dpdk-dev] [PATCH v4 16/18] app/proc-info: sprintf overrun bug De Lara Guarch, Pablo
2018-05-12 1:33 ` Andy Green
[not found] ` <152600320129.53146.5983894189916318956.stgit@localhost.localdomain>
2018-05-11 12:55 ` [dpdk-stable] [dpdk-dev] [PATCH v4 17/18] app/test-bbdev: strcpy ok for allocated string De Lara Guarch, Pablo
[not found] ` <152600320633.53146.1883908043976158624.stgit@localhost.localdomain>
2018-05-11 13:02 ` [dpdk-stable] [dpdk-dev] [PATCH v4 18/18] " De Lara Guarch, Pablo
2018-05-12 1:39 ` Andy Green
[not found] ` <152600318116.53146.3348256529816730536.stgit@localhost.localdomain>
2018-05-11 15:39 ` [dpdk-stable] [dpdk-dev] [PATCH v4 13/18] net/vdev_netvsc: readlink inputs cannot be aliased De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CD089E9@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=andy@warmcat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).