From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Vijaya Mohan Guvva <vguvva@caviumnetworks.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH V2] librte_hash: new hash del abi to return stored value
Date: Thu, 17 May 2018 08:06:00 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CD0CC5E@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1526520393-19295-1-git-send-email-vguvva@caviumnetworks.com>
Hi Vijaya,
> -----Original Message-----
> From: Vijaya Mohan Guvva [mailto:vguvva@caviumnetworks.com]
> Sent: Thursday, May 17, 2018 2:27 AM
> To: Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Vijaya Mohan Guvva <vguvva@caviumnetworks.com>
> Subject: [PATCH V2] librte_hash: new hash del abi to return stored value
>
You are actually adding new API, not ABI, so I would reword the commit message.
"hash: add API to return stored value at deletion" maybe?
I would add some information in the commit message and move the changelog (V1, V2 notes)
after the three dashes.
> V2:
> Adding another new interface rte_hash_del_key_data to delete key from hash
> table and return stored data.
>
> V1:
> Add a new key delete interface rte_hash_del_key_with_hash_data to delete the
> key from hash and return the value stored. This is useful for hash users to free
> the data stored in the table after key delete and to avoid maintaining a user data
> array in the dpdk application.
>
> Signed-off-by: Vijaya Mohan Guvva <vguvva@caviumnetworks.com>
> ---
> lib/librte_hash/rte_cuckoo_hash.c | 30 +++++++++++++++++++++++---
> lib/librte_hash/rte_hash.h | 45
> +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 72 insertions(+), 3 deletions(-)
...
> +int32_t
> +rte_hash_del_key_with_hash_data(const struct rte_hash *h, const void *key,
> + hash_sig_t sig, void **data);
> +
> +/**
> * Remove a key from an existing hash table.
> * This operation is not multi-thread safe
> * and should only be called from one thread.
> --
> 1.8.3.1
You need to update the version.map file to add the two new functions
(you might need to wait until 18.05 is released, so you can use the 18.08 tag).
next prev parent reply other threads:[~2018-05-17 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 1:26 Vijaya Mohan Guvva
2018-05-17 8:06 ` De Lara Guarch, Pablo [this message]
2018-05-24 17:47 ` Wang, Yipeng1
2018-05-24 18:35 Guvva, Vijaya
2018-05-25 1:58 ` Honnappa Nagarahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CD0CC5E@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=vguvva@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).