From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Shally Verma <shally.verma@caviumnetworks.com>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"pathreya@caviumnetworks.com" <pathreya@caviumnetworks.com>,
"mchalla@caviumnetworks.com" <mchalla@caviumnetworks.com>,
Ashish Gupta <ashish.gupta@caviumnetworks.com>,
Sunila Sahu <sunila.sahu@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH v1 2/7] compress/octeontx: add device setup PMD ops
Date: Tue, 19 Jun 2018 22:15:20 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8D8545@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1528194913-25893-3-git-send-email-shally.verma@caviumnetworks.com>
> -----Original Message-----
> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
> Sent: Tuesday, June 5, 2018 11:35 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org;
> pathreya@caviumnetworks.com; mchalla@caviumnetworks.com; Ashish Gupta
> <ashish.gupta@caviumnetworks.com>; Sunila Sahu
> <sunila.sahu@caviumnetworks.com>
> Subject: [PATCH v1 2/7] compress/octeontx: add device setup PMD ops
>
> implement device configure and PMD ops.
> setup stream resource memory pool
> setup and enable hardware queue
>
> Signed-off-by: Ashish Gupta <ashish.gupta@caviumnetworks.com>
> Signed-off-by: Shally Verma <shally.verma@caviumnetworks.com>
> Signed-off-by: Sunila Sahu <sunila.sahu@caviumnetworks.com>
> ---
> drivers/compress/octeontx/include/zip_regs.h | 721
> +++++++++++++++++++++++++++
> drivers/compress/octeontx/zip_pmd.c | 269 ++++++++++
> drivers/compress/octeontx/zipvf.c | 81 +++
> drivers/compress/octeontx/zipvf.h | 103 ++++
> 4 files changed, 1174 insertions(+)
..
> diff --git a/drivers/compress/octeontx/zip_pmd.c
> b/drivers/compress/octeontx/zip_pmd.c
> index 1181bed19..3bb7f6896 100644
> --- a/drivers/compress/octeontx/zip_pmd.c
> +++ b/drivers/compress/octeontx/zip_pmd.c
...
> +
> +/** Start device */
> +static int
> +zip_pmd_start(struct rte_compressdev *dev) {
> + if (dev == NULL)
> + return -1;
> + return 0;
> +}
Dev cannot be NULL at this stage, so no need to have this check.
> +
> +/** Stop device */
> +static void
> +zip_pmd_stop(__rte_unused struct rte_compressdev *dev) {
> +
> +}
> +
> +/** Close device */
> +static int
> +zip_pmd_close(struct rte_compressdev *dev) {
> + if (dev == NULL)
> + return -1;
Same as above.
> +
> + struct zip_vf *vf = (struct zip_vf *)dev->data->dev_private;
> +
> + for (int i = 0; dev->data->nb_queue_pairs; i++) {
> + if (dev->data->queue_pairs[i] != NULL)
> + /* qp not released, return error */
> + return -1;
All queue pairs should be released at this point, so not sure this check is required.
If it is, don't forget the indentation.
> + }
> +
> + rte_mempool_free(vf->zip_mp);
> + return 0;
> +}
> +
>
next prev parent reply other threads:[~2018-06-19 22:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 10:35 [dpdk-dev] [PATCH v1 0/7] compress: add Octeontx ZIP compression PMD Shally Verma
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 1/7] compress/octeontx: add octeontx zip PMD support Shally Verma
2018-06-10 10:38 ` Jerin Jacob
2018-06-20 6:32 ` Verma, Shally
2018-06-19 22:15 ` De Lara Guarch, Pablo
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 2/7] compress/octeontx: add device setup PMD ops Shally Verma
2018-06-19 22:15 ` De Lara Guarch, Pablo [this message]
2018-06-20 6:04 ` Verma, Shally
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 3/7] compress/octeontx: add xform and stream create support Shally Verma
2018-06-19 22:13 ` De Lara Guarch, Pablo
2018-06-20 6:12 ` Verma, Shally
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 4/7] compress/octeontx: add ops enq deq apis Shally Verma
2018-06-19 22:18 ` De Lara Guarch, Pablo
2018-06-29 7:42 ` Verma, Shally
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 5/7] test: add octeontx zip PMD for compressdev tests Shally Verma
2018-06-19 22:18 ` De Lara Guarch, Pablo
2018-06-20 6:03 ` Verma, Shally
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 6/7] doc: add octeontx zip PMD documentation Shally Verma
2018-06-14 11:22 ` Kovacevic, Marko
2018-06-19 22:22 ` De Lara Guarch, Pablo
2018-06-05 10:35 ` [dpdk-dev] [PATCH v1 7/7] drivers/compress: add meson.build support Shally Verma
2018-06-19 22:30 ` De Lara Guarch, Pablo
2018-06-20 6:02 ` Verma, Shally
2018-06-20 7:25 ` De Lara Guarch, Pablo
2018-06-20 7:36 ` Verma, Shally
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8977F8D8545@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=ashish.gupta@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=mchalla@caviumnetworks.com \
--cc=pathreya@caviumnetworks.com \
--cc=shally.verma@caviumnetworks.com \
--cc=sunila.sahu@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).