From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Vemula, Hari KumarX" <hari.kumarx.vemula@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] crypto/scheduler: add dynamic logging to scheduler
Date: Wed, 27 Jun 2018 14:44:46 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8DD9B3@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1528781694-9020-1-git-send-email-hari.kumarx.vemula@intel.com>
Hi Hari,
> -----Original Message-----
> From: Vemula, Hari KumarX
> Sent: Tuesday, June 12, 2018 6:35 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Vemula, Hari KumarX
> <hari.kumarx.vemula@intel.com>
> Subject: [PATCH v2] crypto/scheduler: add dynamic logging to scheduler
>
> From: hvemulax <hari.kumarx.vemula@intel.com>
>
> 1.added new logtype for driver.
> 2.registered the new logtype.
> 3.CS_LOG_ERR and RTE_LOG logtypes are replaced with new logtype name.
>
> Signed-off-by: Hari Kumar <hari.kumarx.vemula@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Some lines are too long now, due to the new macro.
Could you change it to a shorter name? Maybe "CR_SCHED_LOG".
Also, make the following changes:
- Change title to: "crypto/scheduler: add dynamic logging", to avoid duplications
- Modify author to "Hari Kumar"
- Remove unused " CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER_DEBUG"
from config file.
- Remove extra blank line at the end of rte_cryptodev_scheduler.c
Thanks,
Pablo
next prev parent reply other threads:[~2018-06-27 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 6:56 [dpdk-dev] [PATCH 1/1] " Hari Kumar
2018-06-12 5:34 ` [dpdk-dev] [PATCH v2] " Hari Kumar
2018-06-27 14:44 ` De Lara Guarch, Pablo [this message]
2018-06-29 14:00 ` [dpdk-dev] [PATCH v3] crypto/scheduler: add dynamic logging Hari Kumar
2018-07-03 8:31 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8977F8DD9B3@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=hari.kumarx.vemula@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).