From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
"ashish.gupta@caviumnetworks.com"
<ashish.gupta@caviumnetworks.com>,
"Daly, Lee" <lee.daly@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] compressdev: add huffman encoding flags
Date: Wed, 27 Jun 2018 15:36:23 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8DDC5A@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <348A99DA5F5B7549AA880327E580B435895B5E2C@IRSMSX101.ger.corp.intel.com>
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Wednesday, June 27, 2018 4:23 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> ashish.gupta@caviumnetworks.com; Daly, Lee <lee.daly@intel.com>
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: RE: [PATCH 2/2] compressdev: add huffman encoding flags
>
> Hi Pablo,
>
>
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Wednesday, June 27, 2018 6:51 AM
> > To: Trahe, Fiona <fiona.trahe@intel.com>;
> > ashish.gupta@caviumnetworks.com; Daly, Lee <lee.daly@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Subject: [PATCH 2/2] compressdev: add huffman encoding flags
> >
> > Added Huffman fixed and dynamic encoding feature flags, so an
> > application can query if a device supports these two types, when
> > performing DEFLATE compression.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > drivers/compress/isal/isal_compress_pmd_ops.c | 4 +++-
> > lib/librte_compressdev/rte_comp.c | 4 ++++
> > lib/librte_compressdev/rte_comp.h | 4 ++++
> > 3 files changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c
> > b/drivers/compress/isal/isal_compress_pmd_ops.c
> > index 970a0413b..585f22802 100644
> > --- a/drivers/compress/isal/isal_compress_pmd_ops.c
> > +++ b/drivers/compress/isal/isal_compress_pmd_ops.c
> > @@ -12,7 +12,9 @@
> > static const struct rte_compressdev_capabilities isal_pmd_capabilities[] = {
> > {
> > .algo = RTE_COMP_ALGO_DEFLATE,
> > - .comp_feature_flags =
> RTE_COMP_FF_SHAREABLE_PRIV_XFORM,
> > + .comp_feature_flags =
> RTE_COMP_FF_SHAREABLE_PRIV_XFORM |
> > + RTE_COMP_FF_HUFFMAN_FIXED |
> > + RTE_COMP_FF_HUFFMAN_DYNAMIC,
> > .window_size = {
> > .min = 15,
> > .max = 15,
> > diff --git a/lib/librte_compressdev/rte_comp.c
> > b/lib/librte_compressdev/rte_comp.c
> > index ea7692ae7..9711a86c8 100644
> > --- a/lib/librte_compressdev/rte_comp.c
> > +++ b/lib/librte_compressdev/rte_comp.c
> > @@ -36,6 +36,10 @@ rte_comp_get_feature_name(uint64_t flag)
> > return "SHA2_SHA256_HASH";
> > case RTE_COMP_FF_SHAREABLE_PRIV_XFORM:
> > return "SHAREABLE_PRIV_XFORM";
> > + case RTE_COMP_FF_HUFFMAN_FIXED:
> > + return "HUFFMAN_FIXED";
> > + case RTE_COMP_FF_HUFFMAN_DYNAMIC:
> > + return "HUFFMAN_DYNAMIC";
> [Fiona] Thanks for adding this.
> Just in case any other algos are added in future which also use Huffman
> encoding I'd suggest renaming to include DEFLATE, e.g.
> RTE_COMP_FF_DFL_HUFFMAN_FIXED/DYNAMIC
Since these flags are set per algorithm (in capabilities),
do you think it is needed to specify DEFLATE?
>
>
> > default:
> > return NULL;
> > }
> > diff --git a/lib/librte_compressdev/rte_comp.h
> > b/lib/librte_compressdev/rte_comp.h
> > index 3ce6a80e1..c6a542c0c 100644
> > --- a/lib/librte_compressdev/rte_comp.h
> > +++ b/lib/librte_compressdev/rte_comp.h
> > @@ -62,6 +62,10 @@ extern "C" {
> > * to create as many priv_xforms as it expects to have stateless
> > * operations in-flight.
> > */
> > +#define RTE_COMP_FF_HUFFMAN_FIXED (1ULL << 13)
> > +/**< Fixed huffman enconding is supported */
> > +#define RTE_COMP_FF_HUFFMAN_DYNAMIC (1ULL << 14)
> > +/**< Dynamic huffman enconding is supported */
> [Fiona] typo encoding.
Will fix.
next prev parent reply other threads:[~2018-06-27 15:36 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 5:50 [dpdk-dev] [PATCH 1/2] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-06-27 5:50 ` [dpdk-dev] [PATCH 2/2] compressdev: add huffman encoding flags Pablo de Lara
2018-06-27 15:22 ` Trahe, Fiona
2018-06-27 15:36 ` De Lara Guarch, Pablo [this message]
2018-06-27 17:35 ` Trahe, Fiona
2018-06-28 10:00 ` Daly, Lee
2018-06-27 12:16 ` [dpdk-dev] [PATCH v2 1/2] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-06-27 12:16 ` [dpdk-dev] [PATCH v2 2/2] compressdev: add huffman encoding flags Pablo de Lara
2018-06-28 7:49 ` Trahe, Fiona
2018-06-28 7:48 ` [dpdk-dev] [PATCH v2 1/2] compressdev: replace mbuf scatter gather flag Trahe, Fiona
2018-06-29 10:08 ` Trahe, Fiona
2018-06-27 15:14 ` [dpdk-dev] [PATCH " Trahe, Fiona
2018-06-27 15:33 ` De Lara Guarch, Pablo
2018-07-04 14:10 ` [dpdk-dev] [PATCH v3 1/4] doc: cleanup ISA-L PMD feature matrix Pablo de Lara
2018-07-04 14:10 ` [dpdk-dev] [PATCH v3 2/4] doc: rename compress feature flag Pablo de Lara
2018-07-05 2:41 ` Verma, Shally
2018-07-05 11:03 ` De Lara Guarch, Pablo
2018-07-05 8:07 ` Trahe, Fiona
2018-07-04 14:10 ` [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-07-05 8:38 ` Verma, Shally
2018-07-05 11:05 ` De Lara Guarch, Pablo
2018-07-05 11:12 ` Verma, Shally
2018-07-05 11:25 ` De Lara Guarch, Pablo
2018-07-05 11:58 ` Verma, Shally
2018-07-06 8:40 ` De Lara Guarch, Pablo
2018-07-06 8:53 ` Verma, Shally
2018-07-06 8:59 ` De Lara Guarch, Pablo
2018-07-04 14:10 ` [dpdk-dev] [PATCH v3 4/4] compressdev: add huffman encoding flags Pablo de Lara
2018-07-05 8:14 ` Verma, Shally
2018-07-05 11:21 ` De Lara Guarch, Pablo
2018-07-05 8:10 ` [dpdk-dev] [PATCH v3 1/4] doc: cleanup ISA-L PMD feature matrix Daly, Lee
2018-07-06 2:54 ` [dpdk-dev] [PATCH v4 " Pablo de Lara
2018-07-06 2:54 ` [dpdk-dev] [PATCH v4 2/4] doc: rename compress feature flag Pablo de Lara
2018-07-06 12:17 ` Verma, Shally
2018-07-06 2:54 ` [dpdk-dev] [PATCH v4 3/4] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-07-06 12:33 ` Verma, Shally
2018-07-06 2:54 ` [dpdk-dev] [PATCH v4 4/4] compressdev: add huffman encoding flags Pablo de Lara
2018-07-06 5:27 ` [dpdk-dev] [PATCH v5 1/4] doc: cleanup ISA-L PMD feature matrix Pablo de Lara
2018-07-06 5:27 ` [dpdk-dev] [PATCH v5 2/4] doc: rename compress feature flag Pablo de Lara
2018-07-06 5:28 ` [dpdk-dev] [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-07-07 6:34 ` Verma, Shally
2018-07-09 8:07 ` De Lara Guarch, Pablo
2018-07-06 5:28 ` [dpdk-dev] [PATCH v5 4/4] compressdev: add huffman encoding flags Pablo de Lara
2018-07-07 6:36 ` Verma, Shally
2018-07-09 8:11 ` [dpdk-dev] [PATCH v5 1/4] doc: cleanup ISA-L PMD feature matrix De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8977F8DDC5A@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=ashish.gupta@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=lee.daly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).