From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Pattan, Reshma" <reshma.pattan@intel.com>,
"Poornima, PallantlaX" <pallantlax.poornima@intel.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/null: add dynamic logging to null driver
Date: Wed, 27 Jun 2018 16:27:36 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8DDD09@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1529059456-25450-1-git-send-email-jananeex.m.parthasarathy@intel.com>
Hi Jananee/Pallantla,
> -----Original Message-----
> From: Parthasarathy, JananeeX M
> Sent: Friday, June 15, 2018 11:44 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; Parthasarathy, JananeeX M
> <jananeex.m.parthasarathy@intel.com>; Poornima, PallantlaX
> <pallantlax.poornima@intel.com>
> Subject: [PATCH] crypto/null: add dynamic logging to null driver
>
> 1.added new logtype for null driver.
> 2.registered new logtype.
> 3.NULL_CRYPTO_LOG_ERR, RTE_LOG_ERR and CDEV_LOG_ERR are replaced
> with new logtype name NULL_PMD_LOG.
>
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Could you make the following changes?
- Change the macro to NULL_LOG, to make it shorter.
- Change title to: crypto/null: add dynamic logging
- There is a mismatch between the author name and the name in the Signed-off line.
Could you fix it?
- Set log level of the new type to INFO (see isal_compress_pmd.c)
Thanks,
Pablo
next prev parent reply other threads:[~2018-06-27 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 10:44 Jananee Parthasarathy
2018-06-27 16:27 ` De Lara Guarch, Pablo [this message]
2018-06-29 12:29 ` [dpdk-dev] [PATCH v2] crypto/null: add dynamic logging Jananee Parthasarathy
2018-07-03 8:32 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8977F8DDD09@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=pallantlax.poornima@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).