From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Verma, Shally" <Shally.Verma@cavium.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"ravi1.kumar@amd.com" <ravi1.kumar@amd.com>,
"Jacob, Jerin" <Jerin.JacobKollanukkaran@cavium.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"tdu@semihalf.com" <tdu@semihalf.com>,
"jianjay.zhou@huawei.com" <jianjay.zhou@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 16/16] cryptodev: check if symmetric sessions are supported
Date: Thu, 28 Jun 2018 14:15:42 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8DED61@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <CY4PR0701MB36343436347FD8607FDF9998F04F0@CY4PR0701MB3634.namprd07.prod.outlook.com>
Hi Shally,
> -----Original Message-----
> From: Verma, Shally [mailto:Shally.Verma@cavium.com]
> Sent: Thursday, June 28, 2018 2:40 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; akhil.goyal@nxp.com; ravi1.kumar@amd.com;
> Jacob, Jerin <Jerin.JacobKollanukkaran@cavium.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> tdu@semihalf.com; jianjay.zhou@huawei.com
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v3 16/16] cryptodev: check if symmetric sessions are
> supported
>
>
>
> >-----Original Message-----
> >From: Pablo de Lara [mailto:pablo.de.lara.guarch@intel.com]
> >Sent: 28 June 2018 06:23
> >To: declan.doherty@intel.com; akhil.goyal@nxp.com; Verma, Shally
> ><Shally.Verma@cavium.com>; ravi1.kumar@amd.com; Jacob, Jerin
> ><Jerin.JacobKollanukkaran@cavium.com>; roy.fan.zhang@intel.com;
> >fiona.trahe@intel.com; tdu@semihalf.com; jianjay.zhou@huawei.com
> >Cc: dev@dpdk.org; Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >Subject: [PATCH v3 16/16] cryptodev: check if symmetric sessions are
> >supported
> >
> >External Email
> >
> >Since asymmetric functionality will be implemented soon, not all PMDs
> >must support symmetric sessions.
> >Therefore, a check is added if a device does not implement the
> >symmetric functions, meaning that the device does not support symmetric
> >operations.
> >
> >Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >---
> > lib/librte_cryptodev/rte_cryptodev.c | 4 ++++
> >lib/librte_cryptodev/rte_cryptodev.h | 4 +++-
> > 2 files changed, 7 insertions(+), 1 deletion(-)
> >
> >diff --git a/lib/librte_cryptodev/rte_cryptodev.c
> >b/lib/librte_cryptodev/rte_cryptodev.c
> >index 7af527075..58fb21056 100644
> >--- a/lib/librte_cryptodev/rte_cryptodev.c
> >+++ b/lib/librte_cryptodev/rte_cryptodev.c
> >@@ -1063,6 +1063,8 @@ rte_cryptodev_sym_session_init(uint8_t dev_id,
> >
> > index = dev->driver_id;
> >
> >+ RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->sym_session_configure,
> >+ -ENOTSUP);
> >+
> > if (sess->sess_private_data[index] == NULL) {
> > ret = dev->dev_ops->sym_session_configure(dev, xforms,
> > sess, mp); @@
> >-1107,6 +1109,8 @@ rte_cryptodev_sym_session_clear(uint8_t dev_id,
> > if (dev == NULL || sess == NULL)
> > return -EINVAL;
> >
> >+ RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->sym_session_clear,
> >+ -ENOTSUP);
> >+
> > dev->dev_ops->sym_session_clear(dev, sess);
> >
> > return 0;
> >diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> >b/lib/librte_cryptodev/rte_cryptodev.h
> >index 32a210b00..c1066d01e 100644
> >--- a/lib/librte_cryptodev/rte_cryptodev.h
> >+++ b/lib/librte_cryptodev/rte_cryptodev.h
> >@@ -896,7 +896,8 @@ rte_cryptodev_sym_session_free(struct
> >rte_cryptodev_sym_session *sess);
> > * @return
> > * - On success, zero.
> > * - -EINVAL if input parameters are invalid.
> >- * - -ENOTSUP if crypto device does not support the crypto transform.
> >+ * - -ENOTSUP if crypto device does not support the crypto transform or
> >+ * does not support symmetric operations.
>
> Acked with just one comment here Isn't it sufficient to say if device does not
> support symmetric?
No, because the device could not support a specific algorithm or other parameters,
such as key size, IV size, etc.
next prev parent reply other threads:[~2018-06-28 14:15 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 22:02 [dpdk-dev] [PATCH 0/6] Cryptodev API changes Pablo de Lara
2018-06-08 22:02 ` [dpdk-dev] [PATCH 1/6] cryptodev: replace bus specific struct with generic dev Pablo de Lara
2018-06-21 12:43 ` Akhil Goyal
2018-06-08 22:02 ` [dpdk-dev] [PATCH 2/6] cryptodev: remove max number of sessions per queue Pablo de Lara
2018-06-21 13:03 ` Akhil Goyal
2018-06-08 22:02 ` [dpdk-dev] [PATCH 3/6] cryptodev: remove max number of sessions Pablo de Lara
2018-06-12 11:37 ` Tomasz Duszynski
2018-06-12 13:53 ` De Lara Guarch, Pablo
2018-06-13 6:11 ` Tomasz Duszynski
2018-06-13 8:23 ` De Lara Guarch, Pablo
2018-06-13 10:11 ` Tomasz Duszynski
2018-06-19 13:20 ` Trahe, Fiona
2018-06-25 16:42 ` De Lara Guarch, Pablo
2018-06-08 22:02 ` [dpdk-dev] [PATCH 4/6] cryptodev: remove queue start/stop functions Pablo de Lara
2018-06-21 12:50 ` Akhil Goyal
2018-06-08 22:02 ` [dpdk-dev] [PATCH 5/6] cryptodev: remove old get session size functions Pablo de Lara
2018-06-21 12:59 ` Akhil Goyal
2018-06-22 17:02 ` Verma, Shally
2018-06-25 16:40 ` De Lara Guarch, Pablo
2018-06-26 5:28 ` Verma, Shally
2018-06-26 8:17 ` De Lara Guarch, Pablo
2018-06-08 22:02 ` [dpdk-dev] [PATCH 6/6] cryptodev: replace mbuf scatter gather flag Pablo de Lara
2018-06-18 6:29 ` Akhil Goyal
2018-06-25 16:43 ` De Lara Guarch, Pablo
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 00/15] Cryptodev API changes for 18.08 Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 01/15] cryptodev: replace bus specific struct with generic dev Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 02/15] cryptodev: remove max number of sessions per queue Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 03/15] app/crypto-perf: limit number of sessions Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 04/15] test/crypto: " Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 05/15] examples/l2fwd-crypto: " Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 06/15] examples/ipsec-secgw: check for max supported sessions Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 07/15] crypto/mvsam: parse max number of sessions Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 08/15] cryptodev: define value for unlimited sessions Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 09/15] cryptodev: remove max number of sessions parameter Pablo de Lara
2018-06-29 8:02 ` Tomasz Duszynski
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 10/15] doc: remove unneeded deprecation notice Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 11/15] cryptodev: remove queue start/stop functions Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 12/15] cryptodev: remove old get session size functions Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 13/15] cryptodev: replace mbuf scatter gather flag Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 14/15] cryptodev: remove attach/detach session API Pablo de Lara
2018-06-25 8:48 ` [dpdk-dev] [PATCH v2 15/15] cryptodev: rename PMD symmetric " Pablo de Lara
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 00/16] Cryptodev API changes for 18.08 Pablo de Lara
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 01/16] cryptodev: replace bus specific struct with generic dev Pablo de Lara
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 02/16] cryptodev: remove max number of sessions per queue Pablo de Lara
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 03/16] app/crypto-perf: limit number of sessions Pablo de Lara
2018-07-04 12:13 ` Akhil Goyal
2018-07-04 12:15 ` Akhil Goyal
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 04/16] test/crypto: " Pablo de Lara
2018-07-04 12:21 ` Akhil Goyal
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 05/16] examples/l2fwd-crypto: " Pablo de Lara
2018-07-04 12:04 ` Akhil Goyal
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 06/16] examples/ipsec-secgw: check for max supported sessions Pablo de Lara
2018-07-04 12:30 ` Akhil Goyal
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 07/16] crypto/mvsam: parse max number of sessions Pablo de Lara
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 08/16] cryptodev: define value for unlimited sessions Pablo de Lara
2018-07-04 12:40 ` Akhil Goyal
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 09/16] cryptodev: remove max number of sessions parameter Pablo de Lara
2018-06-29 8:04 ` Tomasz Duszynski
2018-07-02 10:58 ` De Lara Guarch, Pablo
2018-07-04 12:42 ` Akhil Goyal
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 10/16] doc: remove unneeded deprecation notice Pablo de Lara
2018-07-04 11:29 ` Akhil Goyal
2018-06-28 0:52 ` [dpdk-dev] [PATCH v3 11/16] cryptodev: remove queue start/stop functions Pablo de Lara
2018-06-28 0:53 ` [dpdk-dev] [PATCH v3 12/16] cryptodev: remove old get session size functions Pablo de Lara
2018-07-04 11:31 ` Akhil Goyal
2018-06-28 0:53 ` [dpdk-dev] [PATCH v3 13/16] cryptodev: replace mbuf scatter gather flag Pablo de Lara
2018-07-04 12:57 ` Akhil Goyal
2018-07-04 15:53 ` De Lara Guarch, Pablo
2018-06-28 0:53 ` [dpdk-dev] [PATCH v3 14/16] cryptodev: remove attach/detach session API Pablo de Lara
2018-07-04 11:33 ` Akhil Goyal
2018-06-28 0:53 ` [dpdk-dev] [PATCH v3 15/16] cryptodev: rename PMD symmetric " Pablo de Lara
2018-07-04 11:36 ` Akhil Goyal
2018-06-28 0:53 ` [dpdk-dev] [PATCH v3 16/16] cryptodev: check if symmetric sessions are supported Pablo de Lara
2018-06-28 13:40 ` Verma, Shally
2018-06-28 14:15 ` De Lara Guarch, Pablo [this message]
2018-07-04 12:27 ` Akhil Goyal
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 00/16] Cryptodev API changes Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 01/16] cryptodev: replace bus specific struct with generic dev Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 02/16] cryptodev: remove max number of sessions per queue Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 03/16] app/crypto-perf: limit number of sessions Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 04/16] test/crypto: " Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 05/16] examples/l2fwd-crypto: " Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 06/16] examples/ipsec-secgw: check for max supported sessions Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 07/16] crypto/mvsam: parse max number of sessions Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 08/16] cryptodev: define value for unlimited sessions Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 09/16] cryptodev: remove max number of sessions parameter Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 10/16] doc: remove unneeded deprecation notice Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 11/16] cryptodev: remove queue start/stop functions Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 12/16] cryptodev: remove old get session size functions Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 13/16] cryptodev: replace mbuf scatter gather flag Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 14/16] cryptodev: remove attach/detach session API Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 15/16] cryptodev: rename PMD symmetric " Pablo de Lara
2018-07-04 8:51 ` [dpdk-dev] [PATCH v4 16/16] cryptodev: check if symmetric sessions are supported Pablo de Lara
2018-07-05 2:07 ` [dpdk-dev] [PATCH v5 00/16] Cryptodev API changes Pablo de Lara
2018-07-05 2:07 ` [dpdk-dev] [PATCH v5 01/16] cryptodev: replace bus specific struct with generic dev Pablo de Lara
2018-07-05 2:07 ` [dpdk-dev] [PATCH v5 02/16] cryptodev: remove max number of sessions per queue Pablo de Lara
2018-07-05 2:07 ` [dpdk-dev] [PATCH v5 03/16] app/crypto-perf: limit number of sessions Pablo de Lara
2018-07-05 2:07 ` [dpdk-dev] [PATCH v5 04/16] test/crypto: " Pablo de Lara
2018-07-05 11:27 ` Verma, Shally
2018-07-05 11:30 ` Akhil Goyal
2018-07-05 2:07 ` [dpdk-dev] [PATCH v5 05/16] examples/l2fwd-crypto: " Pablo de Lara
2018-07-05 2:07 ` [dpdk-dev] [PATCH v5 06/16] examples/ipsec-secgw: check for max supported sessions Pablo de Lara
2018-07-05 2:07 ` [dpdk-dev] [PATCH v5 07/16] crypto/mvsam: parse max number of sessions Pablo de Lara
2018-07-05 2:07 ` [dpdk-dev] [PATCH v5 08/16] cryptodev: define value for unlimited sessions Pablo de Lara
2018-07-05 2:07 ` [dpdk-dev] [PATCH v5 09/16] cryptodev: remove max number of sessions parameter Pablo de Lara
2018-07-09 10:53 ` De Lara Guarch, Pablo
2018-07-05 2:07 ` [dpdk-dev] [PATCH v5 10/16] doc: remove unneeded deprecation notice Pablo de Lara
2018-07-05 2:08 ` [dpdk-dev] [PATCH v5 11/16] cryptodev: remove queue start/stop functions Pablo de Lara
2018-07-05 2:08 ` [dpdk-dev] [PATCH v5 12/16] cryptodev: remove old get session size functions Pablo de Lara
2018-07-05 2:08 ` [dpdk-dev] [PATCH v5 13/16] cryptodev: replace mbuf scatter gather flag Pablo de Lara
2018-07-05 11:35 ` Akhil Goyal
2018-07-05 2:08 ` [dpdk-dev] [PATCH v5 14/16] cryptodev: remove attach/detach session API Pablo de Lara
2018-07-05 2:08 ` [dpdk-dev] [PATCH v5 15/16] cryptodev: rename PMD symmetric " Pablo de Lara
2018-07-05 2:08 ` [dpdk-dev] [PATCH v5 16/16] cryptodev: check if symmetric sessions are supported Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 00/16] Cryptodev API changes Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 01/16] cryptodev: replace bus specific struct with generic dev Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 02/16] cryptodev: remove max number of sessions per queue Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 03/16] app/crypto-perf: limit number of sessions Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 04/16] test/crypto: " Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 05/16] examples/l2fwd-crypto: " Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 06/16] examples/ipsec-secgw: check for max supported sessions Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 07/16] crypto/mvsam: parse max number of sessions Pablo de Lara
2018-07-10 10:42 ` Tomasz Duszynski
2018-07-10 10:45 ` De Lara Guarch, Pablo
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 08/16] cryptodev: define value for unlimited sessions Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 09/16] cryptodev: remove max number of sessions parameter Pablo de Lara
2018-07-10 8:46 ` Akhil Goyal
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 10/16] doc: remove unneeded deprecation notice Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 11/16] cryptodev: remove queue start/stop functions Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 12/16] cryptodev: remove old get session size functions Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 13/16] cryptodev: replace mbuf scatter gather flag Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 14/16] cryptodev: remove attach/detach session API Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 15/16] cryptodev: rename PMD symmetric " Pablo de Lara
2018-07-10 0:36 ` [dpdk-dev] [PATCH v6 16/16] cryptodev: check if symmetric sessions are supported Pablo de Lara
2018-07-10 11:00 ` [dpdk-dev] [PATCH v6 00/16] Cryptodev API changes De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8977F8DED61@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=Jerin.JacobKollanukkaran@cavium.com \
--cc=Shally.Verma@cavium.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=jianjay.zhou@huawei.com \
--cc=ravi1.kumar@amd.com \
--cc=roy.fan.zhang@intel.com \
--cc=tdu@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).