From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Shally Verma <shally.verma@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"pathreya@caviumnetworks.com" <pathreya@caviumnetworks.com>,
Sunila Sahu <sunila.sahu@caviumnetworks.com>,
Ashish Gupta <ashish.gupta@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/2] test/crypto: add rsa and mod test application
Date: Mon, 9 Jul 2018 18:16:31 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8E85B8@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1530806060-31227-2-git-send-email-shally.verma@caviumnetworks.com>
> -----Original Message-----
> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
> Sent: Thursday, July 5, 2018 4:54 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; pathreya@caviumnetworks.com; Sunila Sahu
> <sunila.sahu@caviumnetworks.com>; Ashish Gupta
> <ashish.gupta@caviumnetworks.com>
> Subject: [PATCH v4 1/2] test/crypto: add rsa and mod test application
Retitle to "add RSA and Mod tests"? No need to use "test application".
>
> From: Sunila Sahu <sunila.sahu@caviumnetworks.com>
>
> Test application include test case for :
> - RSA encrypt, decrypt, sign and verify
> - Modular Inversion and Exponentiation
>
> Test cases uses predefined test vectors.
>
> Signed-off-by: Sunila Sahu <sunila.sahu@caviumnetworks.com>
> Signed-off-by: Shally Verma <shally.verma@caviumnetworks.com>
> Signed-off-by: Ashish Gupta <ashish.gupta@caviumnetworks.com>
> ---
> test/test/Makefile | 1 +
> test/test/meson.build | 1 +
> test/test/test_cryptodev_asym.c | 836
> ++++++++++++++++++++++++++++
> test/test/test_cryptodev_asym_util.h | 45 ++
> test/test/test_cryptodev_mod_test_vectors.h | 103 ++++
> test/test/test_cryptodev_rsa_test_vectors.h | 90 +++
> 6 files changed, 1076 insertions(+)
>
> diff --git a/test/test/Makefile b/test/test/Makefile index eccc8ef..d6fb88f
> 100644
> --- a/test/test/Makefile
> +++ b/test/test/Makefile
> @@ -179,6 +179,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) +=
> test_pmd_ring_perf.c
>
> SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_blockcipher.c
> SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev.c
> +SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_asym.c
>
> ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y)
> SRCS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) += test_compressdev.c diff --git
> a/test/test/meson.build b/test/test/meson.build index a907fd2..06cd6f7 100644
> --- a/test/test/meson.build
> +++ b/test/test/meson.build
> @@ -22,6 +22,7 @@ test_sources = files('commands.c',
> 'test_cpuflags.c',
> 'test_crc.c',
> 'test_cryptodev.c',
> + 'test_cryptodev_asym.c',
> 'test_cryptodev_blockcipher.c',
> 'test_cycles.c',
> 'test_debug.c',
Add new test to test_names list in meson.build.
> diff --git a/test/test/test_cryptodev_asym.c b/test/test/test_cryptodev_asym.c
> new file mode 100644 index 0000000..9b6ffac
> --- /dev/null
> +++ b/test/test/test_cryptodev_asym.c
> @@ -0,0 +1,836 @@
...
> + snprintf(test_msg,
> + ASYM_TEST_MSG_LEN,
> + "Modinv :%s length:%lu\n",
> + asym_op->modinv.base.data,
> + asym_op->modinv.base.length);
There is a compilation error on 32 bits:
test/test/test_cryptodev_asym.c:1046:25: error: format '%lu' expects argument of type 'long unsigned int',
but argument 5 has type 'size_t {aka unsigned int}' [-Werror=format=]
"Modinv :%s length:%lu\n",
~~^
%u
test/test/test_cryptodev_asym.c:1048:4:
asym_op->modinv.base.length);
~~~~~~~~~~~~~~~~~~~~~~~~~~~
next prev parent reply other threads:[~2018-07-09 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 15:54 [dpdk-dev] [PATCH v4 0/2] test/crypto: add testcase for asym crypto Shally Verma
2018-07-05 15:54 ` [dpdk-dev] [PATCH v4 1/2] test/crypto: add rsa and mod test application Shally Verma
2018-07-09 18:16 ` De Lara Guarch, Pablo [this message]
2018-07-09 22:14 ` De Lara Guarch, Pablo
2018-07-05 15:54 ` [dpdk-dev] [PATCH v4 2/2] test/crypto: add dh and dsa " Shally Verma
2018-07-09 22:14 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8977F8E85B8@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=ashish.gupta@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=pathreya@caviumnetworks.com \
--cc=shally.verma@caviumnetworks.com \
--cc=sunila.sahu@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).