From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Daly, Lee" <lee.daly@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] compress/isal: fixes offset check
Date: Wed, 1 Aug 2018 08:10:46 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F9086AB@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <1533035316-63812-1-git-send-email-lee.daly@intel.com>
Hi Lee,
> -----Original Message-----
> From: Daly, Lee
> Sent: Tuesday, July 31, 2018 12:09 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Daly, Lee <lee.daly@intel.com>
> Subject: [PATCH] compress/isal: fixes offset check
>
> This commit fixes an offset check in decompression which was checking
> destination offset size against dst data_len rather than checking against dst
> pkt_len as required.
>
> Fixes:788e748d3845 ("compress/isal: support chained mbufs")
>
> Signed-off-by: Lee Daly <lee.daly@intel.com>
> ---
> drivers/compress/isal/isal_compress_pmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/compress/isal/isal_compress_pmd.c
> b/drivers/compress/isal/isal_compress_pmd.c
> index e75f48d..aef56e3 100644
> --- a/drivers/compress/isal/isal_compress_pmd.c
> +++ b/drivers/compress/isal/isal_compress_pmd.c
> @@ -483,7 +483,7 @@ process_isal_inflate(struct rte_comp_op *op, struct
> isal_comp_qp *qp)
> return -1;
> }
>
> - if (op->dst.offset > op->m_dst->data_len) {
> + if (op->dst.offset > op->m_dst->pkt_len) {
Actually, I think you should check if offset is higher or EQUAL to pktlen (>=).
This applies to the isal_deflate function too.
> ISAL_PMD_LOG(ERR, "Output mbuf not big enough for length
> and "
> "offset provided.\n");
I think message should say that mbuf is not big enough for the offset provided,
as length is not passed like in the input mbufs.
> op->status = RTE_COMP_OP_STATUS_INVALID_ARGS;
> --
> 2.7.4
Thanks,
Pablo
next prev parent reply other threads:[~2018-08-01 8:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 11:08 Lee Daly
2018-08-01 8:10 ` De Lara Guarch, Pablo [this message]
2018-08-01 13:23 ` [dpdk-dev] [PATCH v2] " Lee Daly
2018-08-01 13:30 ` De Lara Guarch, Pablo
2018-08-03 9:57 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8977F9086AB@IRSMSX107.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=lee.daly@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).