patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Vemula, Hari KumarX" <hari.kumarx.vemula@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Marohn, Byron" <byron.marohn@intel.com>,
	"Pattan, Reshma" <reshma.pattan@intel.com>,
	"Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v4] lib/efd: fix to free tail queue entry after use
Date: Thu, 17 Jan 2019 16:41:35 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D89780366F0B@irsmsx112.ger.corp.intel.com> (raw)
In-Reply-To: <1547732199-12201-1-git-send-email-hari.kumarx.vemula@intel.com>

Hi,

> -----Original Message-----
> From: Vemula, Hari KumarX
> Sent: Thursday, January 17, 2019 1:37 PM
> To: dev@dpdk.org
> Cc: Marohn, Byron <byron.marohn@intel.com>; Pattan, Reshma
> <reshma.pattan@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Parthasarathy, JananeeX M
> <jananeex.m.parthasarathy@intel.com>; Vemula, Hari KumarX
> <hari.kumarx.vemula@intel.com>; stable@dpdk.org
> Subject: [PATCH v4] lib/efd: fix to free tail queue entry after use
> 
> In rte_efd_create() allocated memory for tail queue entry but not freed.
> Added freeing the tail queue entry.
> 
> Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
> Reviewed-by: Honnappa Nagarahalli <Honnappa.nagarahalli@arm.com>
> ---
> v4: RTE_TAILQ_CAST moved after for loop
> v3: Replaced TAILQ_FOREACH_SAFE with TAILQ_FOREACH
> v2: Updated commit message.
> ---
>  lib/librte_efd/rte_efd.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c index
> e6e5cfda2..b19e707d8 100644
> --- a/lib/librte_efd/rte_efd.c
> +++ b/lib/librte_efd/rte_efd.c
> @@ -740,6 +740,8 @@ void
>  rte_efd_free(struct rte_efd_table *table)  {
>  	uint8_t socket_id;
> +	struct rte_efd_list *efd_list;
> +	struct rte_tailq_entry *te, *temp;
> 
>  	if (table == NULL)
>  		return;
> @@ -747,6 +749,18 @@ rte_efd_free(struct rte_efd_table *table)
>  	for (socket_id = 0; socket_id < RTE_MAX_NUMA_NODES; socket_id++)
>  		rte_free(table->chunks[socket_id]);
> 
> +	efd_list = RTE_TAILQ_CAST(rte_efd_tailq.head, rte_efd_list);
> +	rte_rwlock_write_lock(RTE_EAL_TAILQ_RWLOCK);
> +
> +	TAILQ_FOREACH_SAFE(te, efd_list, next, temp) {
> +		if (te->data == (void *) table) {
> +			TAILQ_REMOVE(efd_list, te, next);
> +			rte_free(te);
> +			te = NULL;

No need to set te = NULL, as it is a local variable.
Also, you can break here, as no duplicates are allowed.

Apart from this two changes:

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

  reply	other threads:[~2019-01-17 16:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 11:45 [dpdk-stable] [PATCH] lib: fix to free trail " Hari Kumar Vemula
2018-11-13 16:43 ` Pattan, Reshma
2018-11-14 11:17 ` [dpdk-stable] [PATCH v2] lib/efd: fix to free tail " Hari Kumar Vemula
2018-11-18 14:57   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-11-23 13:30   ` Maxime Coquelin
2018-11-23 14:39     ` Maxime Coquelin
2019-01-11 11:49 ` [dpdk-stable] [PATCH v3] " Hari Kumar Vemula
2019-01-14 22:30   ` Thomas Monjalon
2019-01-14 22:39     ` [dpdk-stable] [dpdk-dev] " Honnappa Nagarahalli
2019-01-17 13:36 ` [dpdk-stable] [PATCH v4] " Hari Kumar Vemula
2019-01-17 16:41   ` De Lara Guarch, Pablo [this message]
2019-01-18  7:40 ` [dpdk-stable] [PATCH v5] " Hari Kumar Vemula
2019-01-18 18:21   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D89780366F0B@irsmsx112.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=byron.marohn@intel.com \
    --cc=dev@dpdk.org \
    --cc=hari.kumarx.vemula@intel.com \
    --cc=jananeex.m.parthasarathy@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).