From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Loftus, Ciara" <ciara.loftus@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v2] vhost: workaround MQ fails to startup
Date: Wed, 10 May 2017 02:07:09 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A3EBB11DD@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <20170428042917.GN11512@yliu-dev.sh.intel.com>
Hi, all:
The patch which is used to fix the Qemu bug has been accepted in qemu community.
http://patchwork.ozlabs.org/patch/760118/
Thanks
Zhiyong
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Friday, April 28, 2017 12:29 PM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>
> Cc: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org; Loftus, Ciara
> <ciara.loftus@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH v2] vhost: workaround MQ fails to startup
>
> On Thu, Apr 27, 2017 at 12:00:52PM +0200, Maxime Coquelin wrote:
> >
> >
> > On 04/27/2017 11:41 AM, Zhiyong Yang wrote:
> > > vhost since dpdk17.02 + qemu2.7 and above will cause failures of
> > >new connection when negotiating to set MQ. (one queue pair works
> > >well).
> > > Because there exist some bugs in qemu code when introducing
> > >VHOST_USER_PROTOCOL_F_REPLY_ACK to qemu. when dealing with the
> vhost
> > >message VHOST_USER_SET_MEM_TABLE for the second time, qemu indeed
> > >doesn't send the messge (The message needs to be sent only once)but
> > >still will be waiting for dpdk's reply ack, then, qemu is always
> > >freezing. DPDK code indeed works in the right way.
> > > The feature VHOST_USER_PROTOCOL_F_REPLY_ACK has to be disabled by
> > >default at the dpdk side in order to avoid the feature support of
> > >DPDK + qemu at the same time. if doing like that, MQ can works well.
> > >
> > >Cc: stable@dpdk.org
> > >
> > >Reported-by: Ciara Loftus <ciara.loftus@intel.com>
> > >Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> > >Tested-by: Ciara Loftus <ciara.loftus@intel.com>
> > >---
> > >
> > >changes in V2
> > >1. modify "workaround" instead of "fix" in the title.
> > >2. add a simple comment suggested by yuanhan
> > >
> > > lib/librte_vhost/vhost_user.h | 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> >
> > Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Applied to dpdk-next-virtio.
>
> Thanks.
>
> --yliu
prev parent reply other threads:[~2017-05-10 2:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1493274893-40764-1-git-send-email-zhiyong.yang@intel.com>
2017-04-27 9:41 ` Zhiyong Yang
2017-04-27 10:00 ` Maxime Coquelin
2017-04-28 4:29 ` Yuanhan Liu
2017-05-10 2:07 ` Yang, Zhiyong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A3EBB11DD@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).