From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/6] fix port id type
Date: Fri, 13 Oct 2017 02:04:58 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8AF43DB1@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <adac1932-221b-63f4-3bd1-74ea214a82dd@intel.com>
Hi Ferruh,
The patch (ethdev: increase port_id range) tend to increase port id range in ethdev, not eventdev,
Do you mean we should change eventdev port id ?
Before V2, that patchset includes eventdev port id extension.
but Bruce reminded me about it in that patchset v2 thread and suggest to send a
separate patch/patchset to fix it if required. So, I didn’t touch the event related files after v2.
If required, I can send eventdev port id range patch soon.
FYI.
Discussion in V2 patch
> > > Fix some checkpatch issues from the original code and remove some
> > > unnecessary cast operations.
> > >
> > > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> > > ---
> > > app/pdump/main.c | 2 +-
> > > app/test-eventdev/test_perf_common.h | 6 +-
> > > app/test-pmd/cmdline.c | 4 +-
> > > app/test-pmd/config.c | 4 +-
> > > app/test-pmd/testpmd.c | 18 +-
> > > app/test-pmd/testpmd.h | 2 +-
> > > drivers/event/octeontx/ssovf_evdev.c | 6 +-
> > > drivers/event/octeontx/ssovf_evdev.h | 4 +-
> > > drivers/event/skeleton/skeleton_eventdev.c | 4 +-
> > > drivers/event/skeleton/skeleton_eventdev.h | 2 +-
> > > drivers/event/sw/sw_evdev.c | 4 +-
> > > drivers/event/sw/sw_evdev.h | 6 +-
> > > drivers/event/sw/sw_evdev_xstats.c | 8 +-
> >
> > These are not ethdev drivers, but eventdev ones. I don't think
> > eventdev needs to go to 16-bit port numbers, but there is no harm in doing so.
> > However, it would be best to modify eventdev drivers in a separate
> > patch - or even patchset.
> >
>
> I will remove them and focus on ethdev in the patchset.
Thanks
Zhiyong
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, October 13, 2017 4:13 AM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/6] fix port id type
>
> On 10/12/2017 7:03 PM, Ferruh Yigit wrote:
> > On 10/12/2017 10:32 AM, Zhiyong Yang wrote:
> >> Now ethdev port_id has been increased to uint16_t from uint8_t in the
> >> below patch http://www.dpdk.org/dev/patchwork/patch/29418/
> >>
> >> but
> >> 1. Some features which are applied were still developed based on
> >> older version uint8_t port_id.
> >> 2. Some places using port id such as testpmd are omitted in previous patch.
> >> The patchset fixes some port id type issues.
> >>
> >> Zhiyong Yang (6):
> >> lib/librte_ether: fix port id type
> >> net/bnxt: fix port id type
> >> net/liquidio: fix port id type
> >> app/pdump: fix port id type
> >> app/proc_info: fix port id type
> >> app/testpmd: fix port id type
> >
> > Series applied to dpdk-next-net/master, thanks.
> >
> >
> > Thanks for the patches!
> > But I can see there are still more uint8_t usage [1], some looks valid.
> >
> > I aware this looks like never it will never end but would you mind
> > doing one more go? It would be nice to get all fixed before rc1.
> > And I hope we won't need to change port_id storage type again...
> >
> >
> > [1]
> > $ git grep -c "uint8_t port_id"
>
> And (git grep "uint8_t port") yields even more result.
>
> > app/test-eventdev/test_order_common.h:2
> > app/test-eventdev/test_perf_common.h:2
> > doc/guides/prog_guide/eventdev.rst:1
> > doc/guides/prog_guide/poll_mode_drv.rst:1
> > doc/guides/prog_guide/rte_flow.rst:6
> > doc/guides/sample_app_ug/kernel_nic_interface.rst:4
> > doc/guides/sample_app_ug/link_status_intr.rst:1
> > drivers/event/dpaa2/dpaa2_eventdev.c:2
> > drivers/event/octeontx/ssovf_evdev.c:2
> > drivers/event/skeleton/skeleton_eventdev.c:2
> > drivers/event/skeleton/skeleton_eventdev.h:1
> > drivers/event/sw/sw_evdev.c:2
> > drivers/event/sw/sw_evdev_xstats.c:1
> > drivers/net/bonding/rte_eth_bond_pmd.c:1
> > drivers/net/i40e/i40e_ethdev.c:1
> > examples/ethtool/lib/rte_ethtool.c:21
> > examples/ethtool/lib/rte_ethtool.h:21
> > examples/eventdev_pipeline_sw_pmd/main.c:6
> > examples/ipsec-secgw/ipsec-secgw.c:2
> > examples/l2fwd-jobstats/main.c:1
> > examples/quota_watermark/qw/init.c:2
> > examples/quota_watermark/qw/init.h:2
> > examples/quota_watermark/qw/main.c:1
> > examples/server_node_efd/node/node.c:2
> > examples/tep_termination/vxlan_setup.c:1
> > examples/tep_termination/vxlan_setup.h:2
> > lib/librte_eventdev/rte_event_eth_rx_adapter.c:1
> > lib/librte_eventdev/rte_eventdev.c:7
> > lib/librte_eventdev/rte_eventdev.h:11
> > lib/librte_eventdev/rte_eventdev_pmd.h:2
> > test/test/test_link_bonding.c:1
> > test/test/test_link_bonding_mode4.c:2
> > test/test/test_link_bonding_rssconf.c:3
> >
next prev parent reply other threads:[~2017-10-13 2:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 9:32 Zhiyong Yang
2017-10-12 9:32 ` [dpdk-dev] [PATCH 1/6] lib/librte_ether: " Zhiyong Yang
2017-10-12 9:32 ` [dpdk-dev] [PATCH 2/6] net/bnxt: " Zhiyong Yang
2017-10-12 9:32 ` [dpdk-dev] [PATCH 3/6] net/liquidio: " Zhiyong Yang
2017-10-12 9:32 ` [dpdk-dev] [PATCH 4/6] app/pdump: " Zhiyong Yang
2017-10-12 9:32 ` [dpdk-dev] [PATCH 5/6] app/proc_info: " Zhiyong Yang
2017-10-12 9:32 ` [dpdk-dev] [PATCH 6/6] app/testpmd: " Zhiyong Yang
2017-10-12 18:03 ` [dpdk-dev] [PATCH 0/6] " Ferruh Yigit
2017-10-12 20:12 ` Ferruh Yigit
2017-10-13 2:04 ` Yang, Zhiyong [this message]
2017-10-13 2:20 ` Ferruh Yigit
2017-10-13 2:31 ` Yang, Zhiyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A8AF43DB1@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).