From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type
Date: Thu, 19 Oct 2017 00:55:40 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8AF479DF@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC35EB8@IRSMSX108.ger.corp.intel.com>
Hi Pablo,
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Wednesday, October 18, 2017 9:10 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Yang, Zhiyong
> <zhiyong.yang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type
>
> Hi Zhiyong,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhiyong Yang
> > Sent: Wednesday, October 18, 2017 10:50 AM
> > To: dev@dpdk.org
> > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Yang, Zhiyong
> > <zhiyong.yang@intel.com>
> > Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type
> >
> > Fix port id issue and remove unnecessary cast.
> >
> > Fixes: f8244c6399d9 ("ethdev: increase port id range")
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
>
> Actually, I think we can extend this patch to declare all variables related to port
> ids to uint16_t.
> I have seen the following: "l2fwd_dst_ports", "portid", "dest_portid", "dst_port".
>
> Rest of the patch looks good to me, so you can keep the ack if you are doing a
> v2.
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
Thanks for your review and acked by. I can do as you comment in V2.
zhiyong
next prev parent reply other threads:[~2017-10-19 0:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 9:50 Zhiyong Yang
2017-10-18 13:10 ` De Lara Guarch, Pablo
2017-10-19 0:55 ` Yang, Zhiyong [this message]
2017-10-19 2:56 ` [dpdk-dev] [PATCH v2] " Zhiyong Yang
2017-10-19 3:06 ` Yang, Zhiyong
2017-10-19 19:10 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A8AF479DF@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).