DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"Tan, Jianfeng" <jianfeng.tan@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"yliu@fridaylinux.org" <yliu@fridaylinux.org>
Cc: "Wang, Wei W" <wei.w.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario
Date: Thu, 21 Dec 2017 08:40:33 +0000	[thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8B019B5A@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <6c8cb663-cde2-5d71-d661-690551f0d247@redhat.com>



> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Thursday, December 21, 2017 4:26 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; Tan, Jianfeng
> <jianfeng.tan@intel.com>; dev@dpdk.org; yliu@fridaylinux.org
> Cc: Wang, Wei W <wei.w.wang@intel.com>
> Subject: Re: [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting
> VM2VM scenario
> 
> 
> 
> On 12/21/2017 07:26 AM, Yang, Zhiyong wrote:
> >
> >
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Zhiyong
> >> Sent: Thursday, December 21, 2017 2:21 PM
> >> To: Tan, Jianfeng <jianfeng.tan@intel.com>; Maxime Coquelin
> >> <maxime.coquelin@redhat.com>; dev@dpdk.org; yliu@fridaylinux.org
> >> Cc: Wang, Wei W <wei.w.wang@intel.com>
> >> Subject: Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci
> >> PMD supporting VM2VM scenario
> >>
> >> Hi Jianfeng,
> >>
> >>> -----Original Message-----
> >>> From: Tan, Jianfeng
> >>> Sent: Thursday, December 21, 2017 1:52 PM
> >>> To: Yang, Zhiyong <zhiyong.yang@intel.com>; Maxime Coquelin
> >>> <maxime.coquelin@redhat.com>; dev@dpdk.org; yliu@fridaylinux.org
> >>> Cc: Wang, Wei W <wei.w.wang@intel.com>
> >>> Subject: RE: [PATCH 00/11] net/vhostpci: A new vhostpci PMD
> >>> supporting VM2VM scenario
> >>>
> >>> Hi,
> >>>
> >>>> -----Original Message-----
> >>>> From: Yang, Zhiyong
> >>>> Sent: Wednesday, December 20, 2017 9:52 AM
> >>>> To: Maxime Coquelin; dev@dpdk.org; yliu@fridaylinux.org
> >>>> Cc: Wang, Wei W; Tan, Jianfeng
> >>>> Subject: RE: [PATCH 00/11] net/vhostpci: A new vhostpci PMD
> >>>> supporting VM2VM scenario
> >>>>
> >>>> Hi Maxime,
> >>>>
> >>>>> -----Original Message-----
> >>>>> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> >>>>> Sent: Tuesday, December 19, 2017 7:15 PM
> >>>>> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org;
> >>>>> yliu@fridaylinux.org
> >>>>> Cc: Wang, Wei W <wei.w.wang@intel.com>; Tan, Jianfeng
> >>>>> <jianfeng.tan@intel.com>
> >>>>> Subject: Re: [PATCH 00/11] net/vhostpci: A new vhostpci PMD
> >>>>> supporting VM2VM scenario
> >>>>>
> >>>>
> >>>> <snip>
> >>>>
> >>>>> Thanks for the RFC.
> >>>>> It seems there is a lot of code duplication between this series
> >>>>> and
> >>>>> libvhost-
> >>>> user.
> >>>>>
> >>>>> Does the non-RFC would make reuse of libvhost-user? I'm thinking
> >>>>> of all
> >>>> the
> >>>>> code copied from virtio-net.c for example.
> >>>>>
> >>>>> If not, I think this is problematic as it will double the maintenance cost.
> >>>>
> >>>> Thank you for paying attention to the patchset . TX/RX logic
> >>>> basically comes from vhost user code.
> >>>> but some function interfaces and data structures are different,  So
> >>>> can not reuse them directly, code duplicate should be removed, I'm
> >>>> aware of this point too, when I was writing the vhostpci PMD.
> >>>>   But We should modify the  libvhost-user firstly,  let
> >>>> libvhostuser become more generic.
> >>>> It looks like that more and more PMDs are becoming the member of
> >>>> virtio family or are on the road.
> >>>
> >>> Trying to draw a conclusion here, there are two kinds of code
> >>> duplication in net/vhost-pci.
> >>> - For pci operations in guest driver, it has some duplicated code
> >>> with virtio-net pmd.
> >>> - For the enqueue/dequeuer operations, it has some duplicated code
> >>> with vhost- user lib.
> >>>
> >>> Right?
> >>
> >> Right. If the existing code in DPDK can become more generic, we can
> >> avoid the duplication.
> >>
> >
> > BTW,  wonder why vhost user enqueue/dequeue are put in lib layer,not in
> driver/net/vhost  like virtio PMD?
> 
> Because Vhost PMD is not its only user, it exports an API that can be used
> directly by the application (e.g. ovs-dpdk).
> 

Thanks for your  detailed clarification. Maxime.

Zhiyong

> Regards,
> Maxime
> 

  reply	other threads:[~2017-12-21  8:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30  9:46 Zhiyong Yang
2017-11-30  9:46 ` [dpdk-dev] [PATCH 01/11] drivers/net: add vhostpci PMD base files Zhiyong Yang
2017-11-30  9:46 ` [dpdk-dev] [PATCH 02/11] net/vhostpci: public header files Zhiyong Yang
2017-11-30  9:46 ` [dpdk-dev] [PATCH 03/11] net/vhostpci: add debugging log macros Zhiyong Yang
2017-11-30  9:46 ` [dpdk-dev] [PATCH 04/11] net/vhostpci: add basic framework Zhiyong Yang
2017-11-30  9:46 ` [dpdk-dev] [PATCH 05/11] net/vhostpci: add queue setup Zhiyong Yang
2017-11-30  9:46 ` [dpdk-dev] [PATCH 06/11] net/vhostpci: add support for link status change Zhiyong Yang
2017-11-30  9:46 ` [dpdk-dev] [PATCH 07/11] net/vhostpci: get remote memory region and vring info Zhiyong Yang
2017-11-30  9:46 ` [dpdk-dev] [PATCH 08/11] net/vhostpci: add RX function Zhiyong Yang
2017-11-30  9:46 ` [dpdk-dev] [PATCH 09/11] net/vhostpci: add TX function Zhiyong Yang
2017-11-30  9:46 ` [dpdk-dev] [PATCH 10/11] net/vhostpci: support RX/TX packets statistics Zhiyong Yang
2017-11-30  9:46 ` [dpdk-dev] [PATCH 11/11] net/vhostpci: update release note Zhiyong Yang
2017-12-05  6:59 ` [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario Yang, Zhiyong
2017-12-05 14:08   ` Yuanhan Liu
2017-12-06  3:00     ` Wei Wang
2017-12-07  6:07   ` Yang, Zhiyong
2017-12-19 11:14 ` Maxime Coquelin
2017-12-20  1:51   ` Yang, Zhiyong
2017-12-21  5:52     ` Tan, Jianfeng
2017-12-21  6:21       ` Yang, Zhiyong
2017-12-21  6:26         ` Yang, Zhiyong
2017-12-21  8:26           ` Maxime Coquelin
2017-12-21  8:40             ` Yang, Zhiyong [this message]
2018-01-11 11:13   ` Yang, Zhiyong
2018-01-18  9:04     ` Maxime Coquelin
2018-01-19  1:56       ` Yang, Zhiyong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A8B019B5A@BGSMSX101.gar.corp.intel.com \
    --to=zhiyong.yang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=wei.w.wang@intel.com \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).