From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: "Chen, Junjie J" <junjie.j.chen@intel.com>,
"yliu@fridaylinux.org" <yliu@fridaylinux.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Chen, Junjie J" <junjie.j.chen@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self
Date: Fri, 29 Dec 2017 06:27:17 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8B01CB02@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <1514542463-146522-1-git-send-email-junjie.j.chen@intel.com>
Hi Junjie,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Junjie Chen
> Sent: Friday, December 29, 2017 6:14 PM
> To: yliu@fridaylinux.org; maxime.coquelin@redhat.com
> Cc: dev@dpdk.org; Chen, Junjie J <junjie.j.chen@intel.com>
> Subject: [dpdk-dev] [PATCH] examples/vhost: fix sending arp packet to self
>
> ARP packets are not dropped when dest vdev is itself, which breaks RX ring
> inconspicuously.
>
If you are fixing a bug, it's better to write one fixline before SOB that can describe which commit caused the issue.
For example,
Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API")
Thanks
Zhiyong
> Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> ---
...
<snip>
next prev parent reply other threads:[~2017-12-29 6:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 10:14 Junjie Chen
2017-12-29 6:27 ` Yang, Zhiyong [this message]
2017-12-29 6:52 ` Chen, Junjie J
2017-12-29 14:33 ` [dpdk-dev] [PATCH v2] " Junjie Chen
2018-01-08 14:14 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A8B01CB02@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=dev@dpdk.org \
--cc=junjie.j.chen@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).