From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: "Zhang, Xiao" <xiao.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [v4] net/i40e: fix SFP X722 not work with FW4.16
Date: Fri, 19 Jul 2019 02:17:37 +0000 [thread overview]
Message-ID: <E3B9F2FDCB65864C82CD632F23D8AB877339C306@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1563533997-10878-1-git-send-email-xiao.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Xiao
> Sent: Friday, July 19, 2019 19:00
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhang, Xiao <xiao.zhang@intel.com>; stable@dpdk.org
> Subject: [v4] net/i40e: fix SFP X722 not work with FW4.16
>
> The code checked the NVM API version of FW to check if support adminq
> operation, when version is 1.7 or above adminq operation is support
> and the adminq flag will be set. The code will use adminq to set TPID if
> the flags set or to use register. The NVM API version of SFP X722 old
> versions are lowwer than 1.7 and for FW4.16 is 1.8. But FW4.16 of SFP
> X722 does not support adminq operation, the legacy logic is not compatible
> with device SFP X722 currently. Check the device id to unset adminq
> flag to use resigter setting to make it work.
>
> Fixes: 73cd7d6dc8e1 ("net/i40e: use set switch AQ instead of register
> setting")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
> ---
Reviewed-by: Haiyue Wang <haiyue.wang@intel.com>
next prev parent reply other threads:[~2019-07-19 2:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1563490319-53151-1-git-send-email-xiao.zhang@intel.com>
2019-07-19 10:26 ` [dpdk-stable] [v3] " Xiao Zhang
2019-07-19 10:59 ` [dpdk-stable] [v4] " Xiao Zhang
2019-07-19 2:17 ` Wang, Haiyue [this message]
2019-07-19 5:26 ` Zhang, Qi Z
2019-07-19 15:30 ` [dpdk-stable] [dpdk-dev] " Stillwell Jr, Paul M
2019-07-19 18:17 ` Ferruh Yigit
2019-07-20 0:53 ` Zhang, Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3B9F2FDCB65864C82CD632F23D8AB877339C306@SHSMSX101.ccr.corp.intel.com \
--to=haiyue.wang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=xiao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).