From: Yong Wang <yongwang@vmware.com>
To: Didier Pallard <didier.pallard@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/8] net/vmxnet3: fix offload issues
Date: Fri, 13 Apr 2018 04:44:15 +0000 [thread overview]
Message-ID: <E4F52E19-FC73-4E4D-B546-4BC4FE7A3E56@vmware.com> (raw)
In-Reply-To: <20180328154349.24976-1-didier.pallard@6wind.com>
On 3/28/18, 8:44 AM, "dev on behalf of Didier Pallard" <dev-bounces@dpdk.org on behalf of didier.pallard@6wind.com> wrote:
This patchset fixes several issues found in vmxnet3 driver
when enabling LRO offload support:
- Rx offload information are not correctly gathered in
multisegmented packets, leading to inconsistent
packet type and Rx offload bits in resulting mbuf
- MSS recovery from offload information is not done
thus LRO mbufs do not contain a correct tso_segsz value.
- MSS value is not propagated by the host on some
hypervisor versions (6.0 for example)
- If two small TCP segments are aggregated in a single
mbuf, an empty segment that only contains offload
information is appended to this segment, and is
propagated as is to the application. But if the application
sends back to the hypervisor a mbuf with an empty
segment, this mbuf is dropped by the hypervisor.
Didier Pallard (8):
net: export IPv6 header extensions skip function
net/vmxnet3: return unknown IPv4 extension len ptype
net/vmxnet3: gather offload data on first and last segment
net/vmxnet3: fix Rx offload information in multiseg packets
net/vmxnet3: complete Rx offloads support
net/vmxnet3: guess mss if not provided in LRO mode
net/vmxnet3: ignore emtpy segments in reception
net/vmxnet3: skip empty segments in transmission
drivers/net/vmxnet3/Makefile | 1 +
drivers/net/vmxnet3/base/vmxnet3_defs.h | 27 ++++-
drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +
drivers/net/vmxnet3/vmxnet3_ethdev.h | 1 +
drivers/net/vmxnet3/vmxnet3_rxtx.c | 200 ++++++++++++++++++++++++++------
lib/librte_net/Makefile | 1 +
lib/librte_net/rte_net.c | 21 ++--
lib/librte_net/rte_net.h | 27 +++++
lib/librte_net/rte_net_version.map | 1 +
9 files changed, 238 insertions(+), 43 deletions(-)
--
2.11.0
Didier, the changes look good overall. Can you describe how did you test this patch set as well as making sure no regression for non-lro case?
next prev parent reply other threads:[~2018-04-13 4:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 15:43 Didier Pallard
2018-03-28 15:43 ` [dpdk-dev] [PATCH 1/8] net: export IPv6 header extensions skip function Didier Pallard
2018-04-17 19:28 ` Ferruh Yigit
2018-04-23 8:35 ` Olivier Matz
2018-03-28 15:43 ` [dpdk-dev] [PATCH 2/8] net/vmxnet3: return unknown IPv4 extension len ptype Didier Pallard
2018-04-16 19:46 ` Yong Wang
2018-04-17 9:09 ` Didier Pallard
2018-03-28 15:43 ` [dpdk-dev] [PATCH 3/8] net/vmxnet3: gather offload data on first and last segment Didier Pallard
2018-03-28 15:43 ` [dpdk-dev] [PATCH 4/8] net/vmxnet3: fix Rx offload information in multiseg packets Didier Pallard
2018-03-28 15:43 ` [dpdk-dev] [PATCH 5/8] net/vmxnet3: complete Rx offloads support Didier Pallard
2018-03-28 15:43 ` [dpdk-dev] [PATCH 6/8] net/vmxnet3: guess mss if not provided in LRO mode Didier Pallard
2018-03-28 15:43 ` [dpdk-dev] [PATCH 7/8] net/vmxnet3: ignore emtpy segments in reception Didier Pallard
2018-03-28 15:43 ` [dpdk-dev] [PATCH 8/8] net/vmxnet3: skip empty segments in transmission Didier Pallard
2018-04-13 4:44 ` Yong Wang [this message]
2018-04-13 14:33 ` [dpdk-dev] [PATCH 0/8] net/vmxnet3: fix offload issues Didier Pallard
2018-04-20 22:02 ` Yong Wang
2018-04-23 14:46 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E4F52E19-FC73-4E4D-B546-4BC4FE7A3E56@vmware.com \
--to=yongwang@vmware.com \
--cc=dev@dpdk.org \
--cc=didier.pallard@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).