From: "Wiles, Keith" <keith.wiles@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] Create kern folder for Linux kernel modules
Date: Fri, 22 Dec 2017 13:59:01 +0000 [thread overview]
Message-ID: <E554161E-F956-4883-924F-9AA38F446C0C@intel.com> (raw)
In-Reply-To: <4919393.KhUSbVM1LT@xps>
> On Dec 22, 2017, at 5:38 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 22/12/2017 11:04, Hemant Agrawal:
>> On 12/22/2017 2:13 PM, Thomas Monjalon wrote:
>>> Hi,
>>>
>>> 22/12/2017 06:57, Hemant Agrawal:
>>>> This patch moves the Linux kernel modules code to a common place.
>>>> - Separate the kernel module code from user space code.
>>>> - The GPL-2.0 licensed code is separated from the BSD-3 licensed userspace
>>>> code
>>>
>>> What is the benefit of separate things by license?
>>
>> The separation makes it easy to identify and check the license.
>>
>> Any patch introducing new file in *non-kern* folders shall not be
>> GPL-2.0 licensed. Or GPL-2.0 license is allowed only for kern folder.
>
> The kernel modules are in DPDK only for historical reasons.
> We should get rid of them, and rely only on upstream modules.
>
> And it should be allowed to have kernel-related files elsewhere.
> Examples: GPL tools or BPF code.
>
>>> These modules are Linux modules, so they should be in the linuxapp dir.
>>
>>
>> This is a cleaner separation w.r.t userspace/kernel space code.
>> *kern* is a better placefolder for LKMs.
>
> I prefer "kernel" name.
The name should be related to Linux in some way, like linux_kern or linux_kernel or linux_modules (this is the one I prefer) this way it make it clear which OS they are designed for.
>
>> Also eal is not getting overloaded.
>>
>> linuxapp is part of librte_eal. KNI is not related to EAL, but still
>> the kni kernel code is added to librte_eal under linuxapp.
>
> Yes it makes sense.
>
> More opinions/votes?
>
>>> There are also some kernel modules in the bsdapp directory.
>>
>> We can move them as well.
Regards,
Keith
next prev parent reply other threads:[~2017-12-22 13:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 5:57 Hemant Agrawal
2017-12-22 8:43 ` Thomas Monjalon
2017-12-22 10:04 ` Hemant Agrawal
2017-12-22 11:38 ` Thomas Monjalon
2017-12-22 13:59 ` Wiles, Keith [this message]
2017-12-22 14:17 ` Thomas Monjalon
2017-12-22 14:51 ` Wiles, Keith
2017-12-22 16:25 ` Hemant Agrawal
2017-12-22 14:28 ` Van Haaren, Harry
2017-12-22 13:05 ` Burakov, Anatoly
2017-12-26 6:46 ` [dpdk-dev] [PATCH v2] kernel folder for Linux and BSD modules Hemant Agrawal
2017-12-26 8:10 ` Tiwei Bie
2017-12-26 8:50 ` Hemant Agrawal
2017-12-26 8:58 ` [dpdk-dev] [PATCH v3] " Hemant Agrawal
2018-01-10 6:46 ` [dpdk-dev] [PATCH v4] " Hemant Agrawal
2018-01-10 11:04 ` Richardson, Bruce
2018-01-12 15:00 ` [dpdk-dev] [PATCH v5] " Hemant Agrawal
2018-02-21 8:09 ` [dpdk-dev] [PATCH v6] " Hemant Agrawal
2018-02-21 10:56 ` Bruce Richardson
2018-02-22 6:09 ` [dpdk-dev] [PATCH v7] " Hemant Agrawal
2018-03-21 18:42 ` Thomas Monjalon
2018-03-22 10:27 ` Bruce Richardson
2018-03-22 10:48 ` Thomas Monjalon
2018-03-22 16:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E554161E-F956-4883-924F-9AA38F446C0C@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).