From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] doc: add contributors guide
Date: Wed, 18 Nov 2015 13:38:21 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA612838CE0@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1445595528-21369-1-git-send-email-john.mcnamara@intel.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John McNamara
> Add a document to explain the DPDK patch submission and review process.
>
> Signed-off-by: John McNamara <john.mcnamara@intel.com>
> +* New external functions should be added to the local ``version.map`` file.
These should be listed alphabetically, perhaps add a note for that.
> + config: enable same drivers options for linux and bsd
> + ixgbe: fix rss in 32 bit
BSD and RSS should be uppercase
> +send them with ``git send-mail``.
<snip>
> +See the `Git send-mail
Typos, should be send-email
+ git alias: fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")'
That line didn't work here - I used the following to set up the alias:
git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")'"
Doxygen isn't mentioned, when creating a new header file, it should get a new page in the API docs.
After improvements listed above,
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
next prev parent reply other threads:[~2015-11-18 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 16:51 [dpdk-dev] [PATCH] add a dpdk " John McNamara
2015-10-15 16:51 ` [dpdk-dev] [PATCH] doc: add " John McNamara
2015-10-15 21:36 ` Thomas Monjalon
2015-10-20 10:58 ` Mcnamara, John
2015-10-20 11:03 ` [dpdk-dev] [PATCH v2] " John McNamara
2015-10-23 10:18 ` [dpdk-dev] [PATCH v3] " John McNamara
2015-11-18 13:38 ` Van Haaren, Harry [this message]
2015-11-20 12:46 ` [dpdk-dev] [PATCH v4] " John McNamara
2015-12-13 22:35 ` Thomas Monjalon
2015-12-14 9:31 ` Mcnamara, John
2015-12-14 20:32 ` [dpdk-dev] [PATCH v2] " John McNamara
2015-12-14 20:46 ` Mcnamara, John
2015-12-14 20:45 ` [dpdk-dev] [PATCH v5] " John McNamara
2015-12-14 22:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA612838CE0@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).