From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Nipun Gupta <nipun.gupta@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Eads, Gage" <gage.eads@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] eventdev: amend timeout criteria comment for burst dequeue
Date: Fri, 10 Feb 2017 10:00:31 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA6129F0E8A@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1486741669-17906-1-git-send-email-nipun.gupta@nxp.com>
> -----Original Message-----
> From: Nipun Gupta [mailto:nipun.gupta@nxp.com]
> Sent: Friday, February 10, 2017 3:48 PM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; jerin.jacob@caviumnetworks.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Eads, Gage <gage.eads@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Nipun Gupta <nipun.gupta@nxp.com>
> Subject: [PATCH v2] eventdev: amend timeout criteria comment for burst dequeue
>
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
Comment inline
> ---
> Changes for v2:
> - Fix errors reported by check-git-log.sh
>
> lib/librte_eventdev/rte_eventdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h
> index c2f9310..49a4739 100644
> --- a/lib/librte_eventdev/rte_eventdev.h
> +++ b/lib/librte_eventdev/rte_eventdev.h
> @@ -1216,7 +1216,7 @@ struct rte_eventdev {
> * - 0 no-wait, returns immediately if there is no event.
> * - >0 wait for the event, if the device is configured with
> * RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT then this function will wait until
> - * the event available or *timeout_ticks* time.
> + * atleast one event is available or *timeout_ticks* time.
at least should have a space between the words.
Send v3 with
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> * if the device is not configured with RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT
> * then this function will wait until the event available or
> * *dequeue_timeout_ns* ns which was previously supplied to
> --
> 1.9.1
next prev parent reply other threads:[~2017-02-10 10:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 15:04 [dpdk-dev] [PATCH] eventdev: amend comment for timeout_ticks in rte_event_dequeue_burst() Nipun Gupta
2017-02-10 15:47 ` [dpdk-dev] [PATCH v2] eventdev: amend timeout criteria comment for burst dequeue Nipun Gupta
2017-02-10 10:00 ` Van Haaren, Harry [this message]
2017-02-10 16:26 ` [dpdk-dev] [PATCH v3] " Nipun Gupta
2017-03-06 13:22 ` Jerin Jacob
2017-03-08 7:29 ` Nipun Gupta
2017-03-08 12:49 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA6129F0E8A@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).