From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Tahhan, Maryam" <maryam.tahhan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Korynkevych, RomanX" <romanx.korynkevych@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] proc-info: added collectd-format and host-id options.
Date: Fri, 3 Mar 2017 14:23:54 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA6129F7D92@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536B50CA44@IRSMSX106.ger.corp.intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tahhan, Maryam
> Sent: Friday, March 3, 2017 1:32 PM
> To: Korynkevych, RomanX <romanx.korynkevych@intel.com>; dev@dpdk.org
> Cc: Korynkevych, RomanX <romanx.korynkevych@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] proc-info: added collectd-format and host-id options.
>
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Roman Korynkevych
> > Sent: Wednesday, March 1, 2017 4:27 PM
> > To: dev@dpdk.org
> > Cc: Korynkevych, RomanX <romanx.korynkevych@intel.com>
> > Subject: [dpdk-dev] [PATCH v3] proc-info: added collectd-format and host-id
> > options.
> >
> > Extended proc-info application to send DPDK port statistics to STDOUT in the
> > format expected by collectd exec plugin. Added HOST ID option to identify the
> > host DPDK process is running on when multiple instance of DPDK are running in
> > parallel. This is needed for the barometer project in OPNFV.
> >
> > Signed-off-by: Roman Korynkevych <romanx.korynkevych@intel.com>
>
> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
Hi Roman,
Just a few pointers on DPDK patch rework / review practice;
- CC people involved in discussion / review of previous versions
- If somebody review / acks your patch, with a request for simple-error rework,
it is allowed to include their Reviewed-by / acked by. Note the changes must
be minor, or keeping the Review/Ack suggested by the person[1]
- When updating a patch, it is good practice to summarize the
changes made under the --- line, so it is easier for reviewers
to see changes made.
That said, no problem, just something to keep in mind for next patches :)
Nice work,
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
[1] http://dpdk.org/dev/patchwork/patch/20898/
next prev parent reply other threads:[~2017-03-03 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 16:52 [dpdk-dev] [PATCH] " Roman Korynkevych
2017-02-27 14:16 ` [dpdk-dev] [PATCH v2] " Roman Korynkevych
2017-02-27 15:18 ` Van Haaren, Harry
2017-03-01 16:27 ` [dpdk-dev] [PATCH v3] " Roman Korynkevych
2017-03-03 13:31 ` Tahhan, Maryam
2017-03-03 14:23 ` Van Haaren, Harry [this message]
2017-03-10 14:32 ` Thomas Monjalon
2017-02-27 15:12 ` [dpdk-dev] [PATCH] " Van Haaren, Harry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA6129F7D92@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=maryam.tahhan@intel.com \
--cc=romanx.korynkevych@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).