From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
Cc: "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
"nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict flags
Date: Thu, 13 Apr 2017 09:36:08 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA612A2CC62@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20170413052927.82842-1-shahafs@mellanox.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Thursday, April 13, 2017 6:29 AM
> To: thomas.monjalon@6wind.com
> Cc: adrien.mazarguil@6wind.com; nelio.laranjeiro@6wind.com; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict flags
>
> Compilation error seen while compiling mlx5 in debug mode
> under RHEL 7.3:
>
> rte_ethdev.h:1670:7: error: type of bit-field 'state' is a GCC extension
> [-Werror=pedantic]
>
> Address it by removing the unnecessary bit-field width limitation.
>
> Fixes: d52268a8b24b ("ethdev: expose device states")
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> lib/librte_ether/rte_ethdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index d07253874..2d1bc12aa 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -1667,7 +1667,7 @@ struct rte_eth_dev {
> * received packets before passing them to the driver for transmission.
> */
> struct rte_eth_rxtx_callback *pre_tx_burst_cbs[RTE_MAX_QUEUES_PER_PORT];
> - enum rte_eth_dev_state state:8; /**< Flag indicating the port state */
> + enum rte_eth_dev_state state; /**< Flag indicating the port state */
> } __rte_cache_aligned;
>
> struct rte_eth_dev_sriov {
What is the guidelines of changing ABI of an @internal structure?
If I understand correctly, this @internal structure shouldn't be allocated in the app - so we can extend it at the end without breaking ABI.
Since the state is at the end of the struct, I think this change is safe.
ABI Validate tool with GCC 5.4.0 says ABI compatible, so
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
next prev parent reply other threads:[~2017-04-13 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 5:29 Shahaf Shuler
2017-04-13 8:29 ` Gaëtan Rivet
2017-04-13 9:36 ` Van Haaren, Harry [this message]
2017-04-19 5:22 ` Shahaf Shuler
2017-04-19 13:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA612A2CC62@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@mellanox.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).