From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"Eads, Gage" <gage.eads@intel.com>,
"nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
"Vangati, Narender" <narender.vangati@intel.com>,
"Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/5] eventdev: introduce specialized enqueue new op variant
Date: Fri, 30 Jun 2017 09:14:22 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA640C3448E@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20170630091156.GA12111@jerin>
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Friday, June 30, 2017 10:12 AM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; hemant.agrawal@nxp.com;
> Eads, Gage <gage.eads@intel.com>; nipun.gupta@nxp.com; Vangati, Narender
> <narender.vangati@intel.com>; Rao, Nikhil <nikhil.rao@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 2/5] eventdev: introduce specialized enqueue new op variant
>
> -----Original Message-----
> > Date: Fri, 30 Jun 2017 08:40:06 +0000
> > From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org"
> > <dev@dpdk.org>
> > CC: "Richardson, Bruce" <bruce.richardson@intel.com>,
> > "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Eads, Gage"
> > <gage.eads@intel.com>, "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
> > "Vangati, Narender" <narender.vangati@intel.com>, "Rao, Nikhil"
> > <nikhil.rao@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH 2/5] eventdev: introduce specialized enqueue
> > new op variant
> >
> > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > > Sent: Thursday, June 29, 2017 3:20 PM
> > > To: dev@dpdk.org
> > <snip>
> > > diff --git a/drivers/event/octeontx/ssovf_evdev.c
> b/drivers/event/octeontx/ssovf_evdev.c
> > > index 8dc7b2ef8..0d0c6a186 100644
> > > --- a/drivers/event/octeontx/ssovf_evdev.c
> > > +++ b/drivers/event/octeontx/ssovf_evdev.c
> > > @@ -158,6 +158,7 @@ ssovf_fastpath_fns_set(struct rte_eventdev *dev)
> > > dev->schedule = NULL;
> > > dev->enqueue = ssows_enq;
> > > dev->enqueue_burst = ssows_enq_burst;
> > > + dev->enqueue_new_burst = ssows_enq_burst;
> > > dev->dequeue = ssows_deq;
> > > dev->dequeue_burst = ssows_deq_burst;
> > >
> > > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> > > index fe2a61e2f..951ad1b33 100644
> > > --- a/drivers/event/sw/sw_evdev.c
> > > +++ b/drivers/event/sw/sw_evdev.c
> > > @@ -796,6 +796,7 @@ sw_probe(struct rte_vdev_device *vdev)
> > > dev->dev_ops = &evdev_sw_ops;
> > > dev->enqueue = sw_event_enqueue;
> > > dev->enqueue_burst = sw_event_enqueue_burst;
> > > + dev->enqueue_new_burst = sw_event_enqueue_burst;
> > > dev->dequeue = sw_event_dequeue;
> > > dev->dequeue_burst = sw_event_dequeue_burst;
> > > dev->schedule = sw_event_schedule;
> >
> >
> > I think it is possible to do this pointer-setting of new_burst() in eventdev.c, instead
> of adding the new_burst() to each PMD individually?
> > During rte_eventdev_configure(), if the dev->enqueue_new_burst() function is NULL, just
> point it at the ordinary one;
>
> I thought so, But it will break in multi process use case as on probe() we are
> updating the callbacks for secondary process. Doing it in probe() may be very
> early as some PMD may update the callback anywhere on or before rte_eventdev_start().
>
> Thoughts?
Ah I forgot about the multi-proc init during my review. The current solution is more appropriate then, so this version
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
next prev parent reply other threads:[~2017-06-30 9:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 14:19 [dpdk-dev] [PATCH 1/5] eventdev: introduce a helper function for enqueue burst Jerin Jacob
2017-06-29 14:19 ` [dpdk-dev] [PATCH 2/5] eventdev: introduce specialized enqueue new op variant Jerin Jacob
2017-06-30 8:40 ` Van Haaren, Harry
2017-06-30 9:11 ` Jerin Jacob
2017-06-30 9:14 ` Van Haaren, Harry [this message]
2017-06-29 14:19 ` [dpdk-dev] [PATCH 3/5] eventdev: introduce specialized enqueue forward " Jerin Jacob
2017-06-29 14:19 ` [dpdk-dev] [PATCH 4/5] event/octeontx: add enqueue new " Jerin Jacob
2017-06-29 14:19 ` [dpdk-dev] [PATCH 5/5] event/octeontx: add enqueue fwd " Jerin Jacob
2017-06-30 2:20 ` Eads, Gage
2017-07-01 12:56 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA640C3448E@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=narender.vangati@intel.com \
--cc=nikhil.rao@intel.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).