From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [Process] Git Fixline Suggestion
Date: Wed, 12 Jul 2017 13:32:31 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA640C3BBBD@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1777813.DZOk1ehyER@xps>
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, July 12, 2017 11:50 AM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [Process] Git Fixline Suggestion
>
> 12/07/2017 10:40, Van Haaren, Harry:
> > Hi All,
> >
> > I propose to add CC: <author> to the output of the git fixline command[1].
> >
> > The logic here is that if it is a fix to the previous code, the original author of that
> code should be informed. Currently the author must read the mailing-list carefully in
> order to ensure that no patches are missed, that fix code that they are the author of.
> >
> > The new workflow is the same as before: copy the output of "git fixline" into the commit
> message. The output would now be two lines as follows:
> >
> > Fixes: 17b8320a3e11 ("vhost: remove index parameter")
> > cc: author@domain.com
> >
> >
> > The following git fixline achieves this:
> >
> > git log -1 --abbrev=12 --format="Fixes: %h (\"%s\")%nCC:%ae"
> >
> >
> > Opinions? -Harry
>
> Good idea.
> Two comments:
>
> - minor nit: CC should be Cc to be consistent with what is suggested
> by check-git-log.sh for stable@dpdk.org.
Sure.
> - Do we want to keep this Cc in the git history or is it just
> to notify people on the mailing list?
> I think it is good to keep in history the tags Acked-by: or Reviewed-by:.
> But if the author does not review the fix, I do not see the benefit of
> saving his name in the history.
Agreed.
I'll send a patch in-reply-to this message to update contributing guidelines.
next prev parent reply other threads:[~2017-07-12 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 8:40 Van Haaren, Harry
2017-07-12 10:49 ` Thomas Monjalon
2017-07-12 13:32 ` Van Haaren, Harry [this message]
2017-07-12 13:38 ` [dpdk-dev] [PATCH] doc: add author on cc to git fixline alias Harry van Haaren
2017-07-24 15:07 ` Adrien Mazarguil
2017-08-03 10:55 ` Mcnamara, John
2017-08-03 13:29 ` Thomas Monjalon
2017-08-03 13:42 ` [dpdk-dev] [PATCH] dev: update " Harry van Haaren
2017-08-03 13:58 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA640C3BBBD@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).