From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] service: add new `rte_service_lcore_count_services` API
Date: Mon, 28 Aug 2017 10:55:05 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA640C6C143@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1503487012-20247-1-git-send-email-pbhagavatula@caviumnetworks.com>
> From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> Sent: Wednesday, August 23, 2017 12:17 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] service: add new `rte_service_lcore_count_services` API
>
> This new API returns the number of services that are running on a specific
> service core. It allows an application to decide which service core to run
> a new service on.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Hi,
Thanks - yes a useful addition to the API. Comments inline below, apart from that, thanks for the addition!
-H
> ---
> lib/librte_eal/common/include/rte_service.h | 12 ++++++++++++
> lib/librte_eal/common/rte_service.c | 11 +++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/lib/librte_eal/common/include/rte_service.h
> b/lib/librte_eal/common/include/rte_service.h
> index 7c6f738..5f0904f 100644
> --- a/lib/librte_eal/common/include/rte_service.h
> +++ b/lib/librte_eal/common/include/rte_service.h
> @@ -374,6 +374,18 @@ int32_t rte_service_lcore_list(uint32_t array[], uint32_t n);
> * @warning
> * @b EXPERIMENTAL: this API may change without prior notice
> *
> + * Get the numer of services running on the supplied lcore.
> + *
> + * @param Lcore Id of the service core.
> + * @retval >=0 Number of services registered to this core.
> + * @retval -EINVAL The provided lcore is not a service core.
> + */
> +int32_t rte_service_lcore_count_services(uint32_t lcore);
Perhaps -ENOTSUP would be clearer for "not a service core"?
Then -EINVAL becomes available to indicate an invalid lcore-id pass in?
> +
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Dumps any information available about the service. If service is NULL,
> * dumps info for all services.
> */
> diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c
> index 7efb76d..ddaed22 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -397,6 +397,17 @@ rte_service_lcore_list(uint32_t array[], uint32_t n)
> }
>
> int32_t
> +rte_service_lcore_count_services(uint32_t lcore)
> +{
/* need to error check lcore here, return -EINVAL if not valid. */
> + struct core_state *cs = &lcore_states[lcore];
> +
> + if (!cs->is_service_core)
> + return -EINVAL;
/* suggesting to use -ENOTSUP instead here */
> +
> + return __builtin_popcountll(cs->service_mask);
> +}
> +
> +int32_t
> rte_service_start_with_defaults(void)
> {
> /* create a default mapping from cores to services, then start the
> --
> 2.7.4
next prev parent reply other threads:[~2017-08-28 10:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 11:16 Pavan Nikhilesh
2017-08-28 10:55 ` Van Haaren, Harry [this message]
2017-08-28 11:06 ` Pavan Nikhilesh Bhagavatula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA640C6C143@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).