From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Yang, Yi Y" <yi.y.yang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] service: fix compilation error
Date: Wed, 20 Sep 2017 09:00:11 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA650FA5C48@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <1505896277-125758-1-git-send-email-yi.y.yang@intel.com>
> From: Yang, Yi Y
> Sent: Wednesday, September 20, 2017 9:31 AM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Yang, Yi Y <yi.y.yang@intel.com>
> Subject: [PATCH] service: fix compilation error
>
> CC rte_service.o
> ./dpdk/lib/librte_eal/common/rte_service.c: In function
> ‘rte_service_start_with_defaults’:
> ./dpdk/lib/librte_eal/common/rte_service.c:449:9:
> error: ‘ids[0]’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
> ret = rte_service_map_lcore_set(i, ids[lcore_iter], 1);
>
> cc1: all warnings being treated as errors
> ./dpdk/mk/internal/rte.compile-pre.mk:138:
> recipe for target 'rte_service.o' failed
>
> Signed-off-by: Yi Yang <yi.y.yang@intel.com>
Hi Yi,
Would you provide a more descriptive commit title
and message please? The compilation output should not be
included in the commit message, instead a short description
of what the error is, and what steps can be taken to
reproduce the error are much more helpful.
The code changes look OK to me - but I'd like to be able
to catch these issues in future, so steps to reproduce are
valuable to me.
Thanks, -Harry
> ---
> lib/librte_eal/common/rte_service.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/rte_service.c
> b/lib/librte_eal/common/rte_service.c
> index 43716bb..e598e16 100644
> --- a/lib/librte_eal/common/rte_service.c
> +++ b/lib/librte_eal/common/rte_service.c
> @@ -431,7 +431,7 @@ rte_service_start_with_defaults(void)
> uint32_t count = rte_service_get_count();
>
> int32_t lcore_iter = 0;
> - uint32_t ids[RTE_MAX_LCORE];
> + uint32_t ids[RTE_MAX_LCORE] = {0};
> int32_t lcore_count = rte_service_lcore_list(ids, RTE_MAX_LCORE);
>
> if (lcore_count == 0)
> --
> 2.1.0
next prev parent reply other threads:[~2017-09-20 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 8:31 Yi Yang
2017-09-20 9:00 ` Van Haaren, Harry [this message]
2017-09-21 1:50 ` Yang, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA650FA5C48@IRSMSX101.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=yi.y.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).