From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Laatz, Kevin" <kevin.laatz@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] meson: add tests to build
Date: Wed, 20 Dec 2017 10:14:39 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA650FE4415@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20171219173131.25125-1-kevin.laatz@intel.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kevin Laatz
> Sent: Tuesday, December 19, 2017 5:32 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Laatz, Kevin
> <kevin.laatz@intel.com>
> Subject: [dpdk-dev] [PATCH] meson: add tests to build
>
> This commit adds most of the remaining tests to the meson build.
> They can be run using test binary as normal.
Cool, thanks for adding more tests!
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
> test/test/meson.build | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/test/test/meson.build b/test/test/meson.build
> index 1a4f894..a9bc2f6 100644
> --- a/test/test/meson.build
> +++ b/test/test/meson.build
> @@ -47,6 +47,8 @@ test_sources = files('commands.c',
> 'test_common.c',
> 'test_cpuflags.c',
> 'test_crc.c',
> + 'test_cryptodev.c',
> + 'test_cryptodev_blockcipher.c',
Each of the test files here exports a number of actual test cases, eg:
RTE>> cryptodev_null_autotest and similar. These test cases should be
added to the list called "test_names" in the same file - so Meson knows
about the tests.
There was talk of refactoring away this list totally - and that would
be good - but for now we're best to keep it in sync with the available
tests.
Apart from the above, the patch looks good to me! Will Review/Ack a v2.
<snip>
next prev parent reply other threads:[~2017-12-20 10:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 17:31 Kevin Laatz
2017-12-19 17:36 ` Laatz, Kevin
2017-12-20 10:14 ` Van Haaren, Harry [this message]
2017-12-20 12:06 ` [dpdk-dev] [PATCH v2] " Kevin Laatz
2018-01-22 14:53 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA650FE4415@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).