From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] event/sw: code refractor to reduce the fetch stall
Date: Tue, 3 Apr 2018 12:47:55 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA65E01BF0B@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <1519932900-10571-1-git-send-email-vipin.varghese@intel.com>
Hey,
> -----Original Message-----
> From: Varghese, Vipin
> Sent: Thursday, March 1, 2018 7:35 PM
> To: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: Varghese, Vipin <vipin.varghese@intel.com>
> Subject: [PATCH 1/2] event/sw: code refractor to reduce the fetch stall
>
> With rearranging the code to prefetch the contents before
> loop check increases performance from single and multistage
> atomic pipeline.
>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
There seems to be a compilation issue with this, see "const" in flow_id.
The flow_id variable is updated later, so it can't be marked const.
After the compilation fix, I see a small performance improvement here,
so you can include my Ack for V2 of this patch:
Acked-by: Harry van Haaren <harry.van.haaren@intel.com
> ---
> drivers/event/sw/sw_evdev_scheduler.c | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/event/sw/sw_evdev_scheduler.c
> b/drivers/event/sw/sw_evdev_scheduler.c
> index e3a41e0..70d1970 100644
> --- a/drivers/event/sw/sw_evdev_scheduler.c
> +++ b/drivers/event/sw/sw_evdev_scheduler.c
> @@ -44,12 +44,13 @@ sw_schedule_atomic_to_cq(struct sw_evdev *sw, struct
> sw_qid * const qid,
> uint32_t qid_id = qid->id;
>
> iq_dequeue_burst(sw, &qid->iq[iq_num], qes, count);
> - for (i = 0; i < count; i++) {
> - const struct rte_event *qe = &qes[i];
> - const uint16_t flow_id = SW_HASH_FLOWID(qes[i].flow_id);
> - struct sw_fid_t *fid = &qid->fids[flow_id];
> - int cq = fid->cq;
>
> + const struct rte_event *qe = &qes[0];
> + const uint16_t flow_id = SW_HASH_FLOWID(qes[0].flow_id);
^^^^^^ remove the const here.
next prev parent reply other threads:[~2018-04-03 12:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 19:34 Vipin Varghese
2018-03-01 19:35 ` [dpdk-dev] [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf Vipin Varghese
2018-04-03 12:50 ` Van Haaren, Harry
2018-04-04 11:51 ` Varghese, Vipin
2018-04-04 12:26 ` Van Haaren, Harry
2018-04-02 8:06 ` [dpdk-dev] [PATCH 1/2] event/sw: code refractor to reduce the fetch stall Jerin Jacob
2018-04-03 12:47 ` Van Haaren, Harry [this message]
2018-04-05 11:24 ` [dpdk-dev] [PATCH v2] " Vipin Varghese
2018-04-05 5:56 ` [dpdk-dev] [PATCH v3] " Vipin Varghese
2018-04-05 8:53 ` Jerin Jacob
2018-04-13 16:19 ` Van Haaren, Harry
2018-04-14 5:28 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA65E01BF0B@IRSMSX101.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).