From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Eads, Gage" <gage.eads@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Rao, Nikhil" <nikhil.rao@intel.com>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] event/sw: support device stop flush callback
Date: Thu, 14 Jun 2018 10:20:08 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA65E25D8FA@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20180531135557.7544-3-gage.eads@intel.com>
> From: Eads, Gage
> Sent: Thursday, May 31, 2018 2:56 PM
> To: dev@dpdk.org
> Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>;
> Rao, Nikhil <nikhil.rao@intel.com>; Carrillo, Erik G
> <erik.g.carrillo@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>
> Subject: [PATCH 2/2] event/sw: support device stop flush callback
>
> This commit also adds a flush callback test to the sw eventdev's selftest
> suite.
>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
One compile warning below, with that fixed;
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
<snip>
> +static void
> +sw_drain_queues(struct rte_eventdev *dev)
> +{
> + struct sw_evdev *sw = sw_pmd_priv(dev);
> + int i, j;
> +
> + for (i = 0; i < sw->qid_count; i++) {
I'm seeing an int vs unsigned comparison between i and sw->qid_count.
> + for (j = 0; j < SW_IQS_MAX; j++)
> + sw_drain_queue(dev, &sw->qids[i].iq[j]);
> + }
> +}
<snip>
next prev parent reply other threads:[~2018-06-14 10:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 13:55 [dpdk-dev] [PATCH 0/2] Improve service stop support Gage Eads
2018-05-31 13:55 ` [dpdk-dev] [PATCH 1/2] service: add mechanism for quiescing a service Gage Eads
2018-06-14 10:12 ` Van Haaren, Harry
2018-05-31 13:55 ` [dpdk-dev] [PATCH 2/2] event/sw: support device stop flush callback Gage Eads
2018-06-14 10:20 ` Van Haaren, Harry [this message]
2018-06-17 12:33 ` Jerin Jacob
2018-06-14 13:51 ` [dpdk-dev] [PATCH v2 0/2] Improve service stop support Gage Eads
2018-06-14 13:51 ` [dpdk-dev] [PATCH v2 1/2] service: add mechanism for quiescing a service Gage Eads
2018-06-18 22:13 ` Thomas Monjalon
2018-06-21 14:09 ` Eads, Gage
2018-06-14 13:51 ` [dpdk-dev] [PATCH v2 2/2] event/sw: support device stop flush callback Gage Eads
2018-06-21 14:23 ` [dpdk-dev] [PATCH v3 0/2] Improve service stop support Gage Eads
2018-06-21 14:23 ` [dpdk-dev] [PATCH v3 1/2] service: add mechanism for quiescing a service Gage Eads
2018-06-21 14:23 ` [dpdk-dev] [PATCH v3 2/2] event/sw: support device stop flush callback Gage Eads
2018-06-24 11:31 ` [dpdk-dev] [PATCH v3 0/2] Improve service stop support Jerin Jacob
-- strict thread matches above, loose matches on Subject: below --
2018-03-05 23:01 [dpdk-dev] [PATCH 1/2] eventdev: add device stop flush callback Gage Eads
2018-03-05 23:01 ` [dpdk-dev] [PATCH 2/2] event/sw: support " Gage Eads
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA65E25D8FA@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=gage.eads@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).