From: "Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir
Date: Fri, 19 Jul 2019 11:09:25 +0000 [thread overview]
Message-ID: <EB47986807B11C41AD0C5C13A40DE88360C063@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <1901807.fy38742gHy@xps>
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, July 18, 2019 11:25 PM
> 18/07/2019 16:03, Herakliusz Lipiec:
> > When building dpdk with differnt kernel headers by specifying
> > RTE_KERNELDIR igb_uio is compiled to directory with a name of the
> > version of kernel thats running on the system instead of the one that
> > dpdk is actually compiled against. Fixed by replacing hardcoded value
> > with value from RTE_KERNELDIR.
>
> missing original commit reference:
> Fixes: 3967af352aeb ("mk: install kernel modules")
>
> > Cc: stable@dpdk.org
> > Cc: bruce.richardson@intel.com
> > Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> >
> > ---
> > resending v1 with corrected cc address for stable and corrected
> > alignment.
>
> It should be marked v2,
> and the alignment is still not correct.
Sorry I forgot to add the change to commit, sending as v2.
>
> > -kerneldir ?= /lib/modules/$(shell uname -r)/extra/dpdk
> > +kerneldir ?= $(subst /build,/extra/dpdk,$(RTE_KERNELDIR))
>
> I would suggest another syntax, easier to read:
>
> kerneldir ?= $(RTE_KERNELDIR:/build=/extra/dpdk)
>
I have tried that before and it didn't seem to solve the issue.
next prev parent reply other threads:[~2019-07-19 11:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190718132912.28250-1-herakliusz.lipiec@intel.com>
2019-07-18 14:03 ` [dpdk-stable] " Herakliusz Lipiec
2019-07-18 22:25 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-07-19 11:09 ` Lipiec, Herakliusz [this message]
2019-07-19 11:36 ` Thomas Monjalon
2019-07-19 17:01 ` Lipiec, Herakliusz
2019-07-19 11:11 ` [dpdk-stable] [PATCH v2] " Herakliusz Lipiec
2019-07-19 17:05 ` [dpdk-stable] [PATCH v3] " Herakliusz Lipiec
2019-07-22 8:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EB47986807B11C41AD0C5C13A40DE88360C063@IRSMSX104.ger.corp.intel.com \
--to=herakliusz.lipiec@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).