From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"shahafs@mellanox.com" <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support
Date: Tue, 5 Sep 2017 08:07:11 +0000 [thread overview]
Message-ID: <ED26CBA2FAD1BF48A8719AEF02201E36512B0439@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <18154944.ikgZCrDS5M@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Tuesday, September 5, 2017 3:31 PM
> To: Tan, Jianfeng
> Cc: Richardson, Bruce; dev@dpdk.org; xen-devel@lists.xenproject.org;
> Mcnamara, John; joao.m.martins@oracle.com;
> jerin.jacob@caviumnetworks.com; shahafs@mellanox.com
> Subject: Re: [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support
>
> 05/09/2017 05:41, Tan, Jianfeng:
> > From: Richardson, Bruce
> > >
> > > Reading the contributors guide section on ABI, specifically
> > > http://dpdk.org/doc/guides/contributing/versioning.html#deprecating-
> an-
> > > entire-abi-version
> > > it seems like we should collapse down the versions to a single one
> > > following the function removal, and also increment the whole library so
> > > version.
> >
> > So for lib/librte_eal/linuxapp/eal/rte_eal_version.map, we should change
> it in below way?
> >
> > DPDK_2.1 {
> > {APIs in DPDK_2.0 except xen APIs}
> > ...
> > };
> >
> > DPDK_16.04 {
> > {APIs in DPDK_2.1 except xen APIs}
> > ...
> > } DPDK_2.1;
>
> No, you don't need to collapse. You can just remove Xen functions.
Thanks.
Besides, two more things:
1. Shall we increase the so version?
2. This patch is about 8K lines long, do we need to split?
next prev parent reply other threads:[~2017-09-05 8:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 18:10 [dpdk-dev] [PATCH 0/6] remove xen dom0 support in DPDK Jianfeng Tan
2017-08-30 18:10 ` [dpdk-dev] [PATCH 1/6] example/vhost_xen: remove Jianfeng Tan
2017-09-04 14:14 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 2/6] net/xenvirt: remove Jianfeng Tan
2017-09-04 14:25 ` Bruce Richardson
2017-09-04 14:50 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 3/6] xen: remove xen dependency in app, examples, test Jianfeng Tan
2017-09-04 14:24 ` Bruce Richardson
2017-09-04 14:51 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 4/6] xen: remove xen dependency in drivers, ether, mempool Jianfeng Tan
2017-09-04 14:51 ` Bruce Richardson
2017-08-30 18:10 ` [dpdk-dev] [PATCH 5/6] eal: remove xen dom0 support Jianfeng Tan
2017-09-04 14:43 ` Bruce Richardson
2017-09-04 14:49 ` Bruce Richardson
2017-09-05 3:41 ` Tan, Jianfeng
2017-09-05 7:31 ` Thomas Monjalon
2017-09-05 8:07 ` Tan, Jianfeng [this message]
2017-09-05 8:34 ` Thomas Monjalon
2017-08-30 18:10 ` [dpdk-dev] [PATCH 6/6] eal: remove API rte_mem_phy2mch Jianfeng Tan
2017-09-04 14:52 ` Bruce Richardson
2017-08-31 8:44 ` [dpdk-dev] [Xen-devel] [PATCH 0/6] remove xen dom0 support in DPDK Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED26CBA2FAD1BF48A8719AEF02201E36512B0439@SHSMSX103.ccr.corp.intel.com \
--to=jianfeng.tan@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=joao.m.martins@oracle.com \
--cc=john.mcnamara@intel.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).