From: "Hu, Jiayu" <jiayu.hu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Yao, Lei A" <lei.a.yao@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO
Date: Tue, 22 Aug 2017 01:00:57 +0000 [thread overview]
Message-ID: <ED946F0BEFE0A141B63BABBD629A2A9B387A4F63@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <a9cfad52-1c79-4e86-e9d6-9fe9e813529b@intel.com>
Hi,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, August 21, 2017 7:04 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>; dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Tan, Jianfeng
> <jianfeng.tan@intel.com>; thomas@monjalon.net; Wu, Jingjing
> <jingjing.wu@intel.com>; Yao, Lei A <lei.a.yao@intel.com>
> Subject: Re: [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO
>
> On 8/17/2017 10:08 AM, Jiayu Hu wrote:
> > The GRO library provides two reassembly modes: lightweight mode and
> > heavyweight mode. This patch is to support the heavyweight mode in
> > csum forwarding engine.
> >
> > With the command "set port <port_id> gro (heavymode|lightmode)
> (on|off)",
> > users can select the lightweight mode or the heavyweight mode to use.
> With
> > the command "set gro flush interval <num>", users can set the interval of
> > flushing GROed packets from reassembly tables for the heavyweight mode.
> > With the command "show port <port_id> gro", users can display GRO
> > configuration.
> >
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
>
> <...>
>
> > lcoreid_t cpuid_idx; /**< index of logical core in CPU id table */
> > @@ -434,13 +436,21 @@ extern struct ether_addr
> peer_eth_addrs[RTE_MAX_ETHPORTS];
> > extern uint32_t burst_tx_delay_time; /**< Burst tx delay time(us) for mac-
> retry. */
> > extern uint32_t burst_tx_retry_num; /**< Burst tx retry number for mac-
> retry. */
> >
> > +#define GRO_HEAVYMODE 0x1
> > +#define GRO_LIGHTMODE 0x2
>
> Why these are not part of the gro library?
> Is the concept "lightweight mode and heavyweight mode" part of gro
> library or implemented only in testpmd?
Lightweight mode and heavyweight mode are two reassembly methods we
provided in the GRO library. For applications, they are just two kinds of APIs.
Applications can select any of them to merge packets.
In testpmd, we want to show how to use these two reassembly modes, so
I define two macros to present them. Users can select which one to use via
command line.
>
> > +
> > #define GRO_DEFAULT_FLOW_NUM 4
> > #define GRO_DEFAULT_ITEM_NUM_PER_FLOW DEF_PKT_BURST
> > +
> > +#define GRO_DEFAULT_FLUSH_INTERVAL 2
> > +#define GRO_MAX_FLUSH_INTERVAL 4
> > +
> > struct gro_status {
> > struct rte_gro_param param;
> > uint8_t enable;
> > };
> > extern struct gro_status gro_ports[RTE_MAX_ETHPORTS];
> > +extern uint32_t gro_flush_interval;
>
> <...>
next prev parent reply other threads:[~2017-08-22 1:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 2:50 [dpdk-dev] [PATCH 0/2] Support the Heavyweight Mode GRO in Testpmd Jiayu Hu
2017-08-10 2:50 ` [dpdk-dev] [PATCH 1/2] app/testpmd: support the heavywight mode GRO Jiayu Hu
2017-08-10 9:50 ` Ferruh Yigit
2017-08-15 6:01 ` Jiayu Hu
2017-08-10 2:50 ` [dpdk-dev] [PATCH 2/2] doc: update testpmd user guide for the heavyweight " Jiayu Hu
2017-08-17 9:08 ` [dpdk-dev] [PATCH v2 0/2] Support the Heavyweight Mode GRO in Testpmd Jiayu Hu
2017-08-17 9:08 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO Jiayu Hu
2017-08-21 11:03 ` Ferruh Yigit
2017-08-22 1:00 ` Hu, Jiayu [this message]
[not found] ` <671112a6-6ac6-7476-4270-be1a0258f06e@intel.com>
2017-08-22 14:27 ` Jiayu Hu
2017-08-21 11:16 ` Ferruh Yigit
2017-08-22 0:53 ` Hu, Jiayu
2017-08-17 9:08 ` [dpdk-dev] [PATCH v2 2/2] doc: update testpmd user guide for the heavyweight " Jiayu Hu
2017-08-21 11:03 ` Ferruh Yigit
2017-08-22 0:52 ` Hu, Jiayu
2017-09-03 6:30 ` [dpdk-dev] [PATCH v3] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO Jiayu Hu
2017-09-20 7:00 ` Yao, Lei A
2017-09-25 10:20 ` Hu, Jiayu
2017-09-26 3:54 ` Hu, Jiayu
2017-09-25 11:11 ` Ferruh Yigit
2017-09-26 6:26 ` [dpdk-dev] [PATCH v4] " Jiayu Hu
2017-09-27 7:23 ` Yao, Lei A
2017-10-06 23:04 ` Ferruh Yigit
2017-10-06 23:26 ` Ferruh Yigit
2017-10-07 0:51 ` Hu, Jiayu
2017-10-07 7:45 ` [dpdk-dev] [PATCH v5] " Jiayu Hu
2017-10-07 7:58 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED946F0BEFE0A141B63BABBD629A2A9B387A4F63@shsmsx102.ccr.corp.intel.com \
--to=jiayu.hu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=lei.a.yao@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).