From: "Hu, Jiayu" <jiayu.hu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Tan, Jianfeng" <jianfeng.tan@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Yao, Lei A" <lei.a.yao@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO
Date: Sat, 7 Oct 2017 00:51:07 +0000 [thread overview]
Message-ID: <ED946F0BEFE0A141B63BABBD629A2A9B387F10B9@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <b7fe8e66-085b-83da-aa32-055ab82b7a6e@intel.com>
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Saturday, October 7, 2017 7:26 AM
> To: Yao, Lei A <lei.a.yao@intel.com>; Hu, Jiayu <jiayu.hu@intel.com>;
> dev@dpdk.org
> Cc: Tan, Jianfeng <jianfeng.tan@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; thomas@monjalon.net; Wu, Jingjing
> <jingjing.wu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: enable the heavyweight
> mode TCP/IPv4 GRO
>
> On 10/7/2017 12:04 AM, Ferruh Yigit wrote:
> > On 9/27/2017 8:23 AM, Yao, Lei A wrote:
> > <...>
> >
> >>> The GRO library provides two modes to reassemble packets. Currently,
> the
> >>> csum forwarding engine has supported to use the lightweight mode to
> >>> reassemble TCP/IPv4 packets. This patch introduces the heavyweight
> mode
> >>> for TCP/IPv4 GRO in the csum forwarding engine.
> >>>
> >>> With the command "set port <port_id> gro on|off", users can enable
> >>> TCP/IPv4 GRO for a given port. With the command "set gro flush
> <cycles>",
> >>> users can determine when the GROed TCP/IPv4 packets are flushed from
> >>> reassembly tables. With the command "show port <port_id> gro", users
> can
> >>> display GRO configuration.
> >>>
> >>> The GRO library doesn't re-calculate checksums for merged packets. If
> >>> users want the merged packets to have correct IP and TCP checksums,
> >>> please select HW IP checksum calculation and HW TCP checksum
> calculation
> >>> for the port which the merged packets are transmitted to.
> >>>
> >>> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> >>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> >> Tested-by: Yao Lei<lei.a.yao@intel.com>
> >
> > Applied to dpdk-next-net/master, thanks.
>
> nope, removing it out back.
>
> There are "uint8_t port_id" usage a few places, now port_id is uint16_t,
> this is new in the repo.
>
> For testpmd you can prefer "portid_t" storage type as well.
>
> Can you please send a new version?
No problem. I will send a new version.
Thanks,
Jiayu
next prev parent reply other threads:[~2017-10-07 0:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 2:50 [dpdk-dev] [PATCH 0/2] Support the Heavyweight Mode GRO in Testpmd Jiayu Hu
2017-08-10 2:50 ` [dpdk-dev] [PATCH 1/2] app/testpmd: support the heavywight mode GRO Jiayu Hu
2017-08-10 9:50 ` Ferruh Yigit
2017-08-15 6:01 ` Jiayu Hu
2017-08-10 2:50 ` [dpdk-dev] [PATCH 2/2] doc: update testpmd user guide for the heavyweight " Jiayu Hu
2017-08-17 9:08 ` [dpdk-dev] [PATCH v2 0/2] Support the Heavyweight Mode GRO in Testpmd Jiayu Hu
2017-08-17 9:08 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO Jiayu Hu
2017-08-21 11:03 ` Ferruh Yigit
2017-08-22 1:00 ` Hu, Jiayu
[not found] ` <671112a6-6ac6-7476-4270-be1a0258f06e@intel.com>
2017-08-22 14:27 ` Jiayu Hu
2017-08-21 11:16 ` Ferruh Yigit
2017-08-22 0:53 ` Hu, Jiayu
2017-08-17 9:08 ` [dpdk-dev] [PATCH v2 2/2] doc: update testpmd user guide for the heavyweight " Jiayu Hu
2017-08-21 11:03 ` Ferruh Yigit
2017-08-22 0:52 ` Hu, Jiayu
2017-09-03 6:30 ` [dpdk-dev] [PATCH v3] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO Jiayu Hu
2017-09-20 7:00 ` Yao, Lei A
2017-09-25 10:20 ` Hu, Jiayu
2017-09-26 3:54 ` Hu, Jiayu
2017-09-25 11:11 ` Ferruh Yigit
2017-09-26 6:26 ` [dpdk-dev] [PATCH v4] " Jiayu Hu
2017-09-27 7:23 ` Yao, Lei A
2017-10-06 23:04 ` Ferruh Yigit
2017-10-06 23:26 ` Ferruh Yigit
2017-10-07 0:51 ` Hu, Jiayu [this message]
2017-10-07 7:45 ` [dpdk-dev] [PATCH v5] " Jiayu Hu
2017-10-07 7:58 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED946F0BEFE0A141B63BABBD629A2A9B387F10B9@shsmsx102.ccr.corp.intel.com \
--to=jiayu.hu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=lei.a.yao@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).