From: "Hu, Jiayu" <jiayu.hu@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "yliu@fridaylinux.org" <yliu@fridaylinux.org>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: support Generic Segmentation Offload
Date: Thu, 7 Dec 2017 06:30:29 +0000 [thread overview]
Message-ID: <ED946F0BEFE0A141B63BABBD629A2A9B38816ED9@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <720f198e-7e6c-7f5a-fc2d-cf303b97f24d@redhat.com>
Hi Maxime,
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Wednesday, December 6, 2017 4:34 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>; dev@dpdk.org
> Cc: yliu@fridaylinux.org; Tan, Jianfeng <jianfeng.tan@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] vhost: support Generic Segmentation
> Offload
>
> Hi Jiayu,
>
> On 11/28/2017 06:28 AM, Jiayu Hu wrote:
> > In virtio, Generic Segmentation Offload (GSO) is the feature for the
> > backend, which means the backend can receive packets with any GSO
> > type.
> >
> > Virtio-net enables the GSO feature by default, and vhost-net supports it.
> > To make live migration from vhost-net to vhost-user possible, this patch
> > enables GSO for vhost-user.
>
> Please note that the application relying on Vhost library may disable
> some features, breaking the migration from vhost-net to vhost-user even
> if all features are supported in the vhost-user lib.
>
> For example, ovs-dpdk disables the following features:
> err = rte_vhost_driver_disable_features(dev->vhost_id,
> 1ULL << VIRTIO_NET_F_HOST_TSO4
> | 1ULL << VIRTIO_NET_F_HOST_TSO6
> | 1ULL << VIRTIO_NET_F_CSUM);
>
>
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> > ---
> > lib/librte_vhost/vhost.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> > index 1cc81c1..04f54cb 100644
> > --- a/lib/librte_vhost/vhost.h
> > +++ b/lib/librte_vhost/vhost.h
> > @@ -204,6 +204,7 @@ struct vhost_msg {
> > (1ULL << VIRTIO_F_VERSION_1) | \
> > (1ULL << VHOST_F_LOG_ALL) | \
> > (1ULL <<
> VHOST_USER_F_PROTOCOL_FEATURES) | \
> > + (1ULL << VIRTIO_NET_F_GSO) | \
>
> This feature is also enabled by default in QEMU, and seems also to be
> acked by default in the virtio-net kernel driver.
>
> Does it have an impact on performance? Be it good or bad.
>
> How to test it?
VIRTIO_NET_F_GSO is the combination of all backend GSO types, like
VIRTIO_NET_F_HOST_UFO and VIRTIO_NET_F_HOST_ECN. Supporting
VIRTIO_NET_F_GSO equals to supporting all backend GSO types.
In the virtio-net driver, VIRTIO_NET_F_GSO influences the offloading abilities of
virtio-net devices. When VIRTIO_NET_F_GSO is negotiated, the virtio-net device has
TSO(_ECN) and UFO turned on by default. It equals to enabling "host_ufo", "host_tso4/6"
and "host_ecn".
About the performance, when VIRTIO_NET_F_GSO is enabled, the device
can send large TCP/UDP packets (exceeding MTU) to the backend. Large packets
can reduce the per-packet overhead. Therefore, I think it's good for performance.
We can test this feature with the following configuration:
Environment:
- one server with two physical interfaces (p1 and p2).
- p1 and p2 are connected physically. p1 is assigned to DPDK and p2 is to kernel.
Steps:
- launch testpmd with p1 and one vhost-user port
- launching qemu with command "gso=on, csum=on". In the VM, you can see
TSO_ECN and UFO of the virtio-net port are enabled by default.
- Run "iperf -u -s ..." on p2
- run "iperf -u -c ... -l 7000B" in the VM. Therefore, iperf client will send large
UDP packets
- "show port xstats all" in testpmd. You can see the vhost-user port receives
large UDP packets from the frontend.
You can also use the above steps to test the vhost-user host_ufo feature.
Thanks,
Jiayu
>
> > (1ULL << VIRTIO_NET_F_HOST_TSO4) | \
> > (1ULL << VIRTIO_NET_F_HOST_TSO6) | \
> > (1ULL << VIRTIO_NET_F_CSUM) | \
> >
>
> Thanks,
> Maxime
next prev parent reply other threads:[~2017-12-07 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 5:28 Jiayu Hu
2017-12-06 8:33 ` Maxime Coquelin
2017-12-07 6:30 ` Hu, Jiayu [this message]
2017-12-25 1:53 ` Yao, Lei A
2017-12-27 14:39 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED946F0BEFE0A141B63BABBD629A2A9B38816ED9@shsmsx102.ccr.corp.intel.com \
--to=jiayu.hu@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).