From: "Hu, Jiayu" <jiayu.hu@intel.com>
To: Ophir Munk <ophirmu@mellanox.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Olga Shern <olgas@mellanox.com>,
Pascal Mazon <pascal.mazon@6wind.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v1] gso: fix marking TCP checksum flag in TCP segments
Date: Wed, 25 Apr 2018 01:51:08 +0000 [thread overview]
Message-ID: <ED946F0BEFE0A141B63BABBD629A2A9B388B5A6B@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <HE1PR0501MB23148CC8B520D185BF5749B1D1880@HE1PR0501MB2314.eurprd05.prod.outlook.com>
Hi Ophir,
> -----Original Message-----
> From: Ophir Munk [mailto:ophirmu@mellanox.com]
> Sent: Tuesday, April 24, 2018 9:53 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; dev@dpdk.org
> Cc: Thomas Monjalon <thomas@monjalon.net>; Olga Shern
> <olgas@mellanox.com>; Pascal Mazon <pascal.mazon@6wind.com>;
> stable@dpdk.org
> Subject: RE: [PATCH v1] gso: fix marking TCP checksum flag in TCP
> segments
>
> Hi Jiayu,
>
> > -----Original Message-----
> > From: Hu, Jiayu [mailto:jiayu.hu@intel.com]
> > Sent: Tuesday, April 24, 2018 3:56 PM
> > To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Ophir Munk
> > <ophirmu@mellanox.com>; dev@dpdk.org
> > Cc: Thomas Monjalon <thomas@monjalon.net>; Olga Shern
> > <olgas@mellanox.com>; Pascal Mazon <pascal.mazon@6wind.com>;
> > stable@dpdk.org
> > Subject: RE: [PATCH v1] gso: fix marking TCP checksum flag in TCP
> segments
> >
> > Hi Konstantin and Ophir,
> >
> ...
> > > Another possibility - might be make chages in librte_gso to allow user
> > > to specify what flags to set for the output packets (probably via
> > > rte_gso_ctx.flag)
> >
> > It would be a solution. We can add flags to rte_gso_ctx.flag and the GSO
> > library can do some extra work (like checksum) according to the flags.
> >
>
> I think that calculating TCP checksums by GSO library should be optional (if
> at all).
> In my case I prefer TAP PMD to do the work which is TAP-specific.
> My original intention in this patch was only to mark PKT_TX_TCP_CKSUM
> flag.
One possible workaround is:
We can have many flags. Some flags are for real checksum calculation, but
some flags can be used to tell the GSO library to prepare HW TCP checksum
offloading. When preparing HW TCP checksum offloading, the GSO library can
only set TCP_CKSUM flag.
Since some the HW drivers have supported rte_eth_tx_prepare(), which
will calculate the pseudo IP header checksum, applications can call
rte_eth_tx_prepare() to do real checksum offloading preparation after calling
the GSO library.
Thanks,
Jiayu
>
> > Thanks,
> > Jiayu
> > >
> > > Konstantin
> > >
> ...
next prev parent reply other threads:[~2018-04-25 1:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 14:20 Ophir Munk
2018-04-22 14:47 ` Ophir Munk
2018-04-23 4:13 ` Hu, Jiayu
2018-04-24 9:44 ` Ophir Munk
2018-04-24 10:56 ` Ananyev, Konstantin
2018-04-24 11:45 ` Ophir Munk
2018-04-24 12:31 ` Ananyev, Konstantin
2018-04-24 12:55 ` Hu, Jiayu
2018-04-24 13:53 ` Ophir Munk
2018-04-25 1:51 ` Hu, Jiayu [this message]
2018-04-24 13:41 ` Ophir Munk
2018-04-24 14:26 ` Ananyev, Konstantin
-- strict thread matches above, loose matches on Subject: below --
2018-04-22 14:19 Ophir Munk
2018-04-30 13:38 ` Luca Boccassi
2018-04-22 14:15 Ophir Munk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED946F0BEFE0A141B63BABBD629A2A9B388B5A6B@shsmsx102.ccr.corp.intel.com \
--to=jiayu.hu@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=pascal.mazon@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).