From: "Hu, Jiayu" <jiayu.hu@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the checksum forwarding engine
Date: Sat, 16 Jun 2018 09:14:54 +0000 [thread overview]
Message-ID: <ED946F0BEFE0A141B63BABBD629A2A9B3890FEB5@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CB37DB@IRSMSX108.ger.corp.intel.com>
Hi Bernard,
> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Thursday, June 14, 2018 10:44 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>; dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Hu, Jiayu
> <jiayu.hu@intel.com>
> Subject: RE: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the
> checksum forwarding engine
>
> Hi Jiayu,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiayu Hu
> > Sent: Tuesday, May 29, 2018 8:41 AM
> > To: dev@dpdk.org
> > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Hu, Jiayu
> > <jiayu.hu@intel.com>
> > Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the
> > checksum forwarding engine
> >
> > This patch enables GSO for UDP/IPv4 packets. Oversized UDP/IPv4
> packets
> > transmitted over a GSO-enabled port will undergo segmentation.
> >
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> > ---
> > app/test-pmd/cmdline.c | 5 +++--
> > app/test-pmd/csumonly.c | 2 ++
> > app/test-pmd/testpmd.c | 2 +-
> > 3 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > 27e2aa8..4239e91 100644
> > --- a/app/test-pmd/cmdline.c
> > +++ b/app/test-pmd/cmdline.c
> > @@ -4792,8 +4792,9 @@ cmd_gso_show_parsed(void *parsed_result,
> > if (gso_ports[res->cmd_pid].enable) {
> > printf("Max GSO'd packet size: %uB\n"
> > "Supported GSO types: TCP/IPv4, "
> > - "VxLAN with inner TCP/IPv4 packet,
> "
> > - "GRE with inner TCP/IPv4
> packet\n",
> > + "UDP/IPv4, VxLAN with inner "
> > + "TCP/IPv4 packet, GRE with inner "
> > + "TCP/IPv4 packet\n",
>
> This change is giving 3 checkpatch.pl warnings and should be refactored
The file test-pmd/cmdline.c uses the above coding style to split long strings,
so I think I need to keep this style. But when I use it, there are always some warnings.
>
>
> > gso_max_segment_size);
> > } else
> > printf("GSO is not enabled on Port %u\n", res-
> > >cmd_pid); diff --git a/app/test-pmd/csumonly.c b/app/test-
> > pmd/csumonly.c index 0bb88cf..4948292 100644
> > --- a/app/test-pmd/csumonly.c
> > +++ b/app/test-pmd/csumonly.c
> > @@ -411,6 +411,8 @@ process_inner_cksums(void *l3_hdr, const struct
> > testpmd_offload_info *info,
> > info->ethertype);
> > }
> > }
> > + if (info->gso_enable)
> > + ol_flags |= PKT_TX_UDP_SEG;
> > } else if (info->l4_proto == IPPROTO_TCP) {
> > tcp_hdr = (struct tcp_hdr *)((char *)l3_hdr + info->l3_len);
> > tcp_hdr->cksum = 0;
> > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> > 35cf266..b5766ff 100644
> > --- a/app/test-pmd/testpmd.c
> > +++ b/app/test-pmd/testpmd.c
> > @@ -777,7 +777,7 @@ init_config(void)
> > init_port_config();
> >
> > gso_types = DEV_TX_OFFLOAD_TCP_TSO |
> > DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
> > - DEV_TX_OFFLOAD_GRE_TNL_TSO;
> > + DEV_TX_OFFLOAD_GRE_TNL_TSO |
> > DEV_TX_OFFLOAD_UDP_TSO;
> > /*
> > * Records which Mbuf pool to use by each logical core, if needed.
> > */
> > --
> > 2.7.4
>
> ./devtools/check-git-log.sh -1
> Headline too long:
> app/testpmd: enable UDP GSO in the checksum forwarding engine
Will change it in the next version.
>
> Should the dpdk/doc/guides/testpmd_ap_ug/testpmd_funcs.rst file be
> updated?
I will add some descriptions about UDP/IPv4 GSO usage guide in it.
Thanks,
Jiayu
>
> Regards,
>
> Bernard
>
next prev parent reply other threads:[~2018-06-16 9:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 7:41 [dpdk-dev] [PATCH 0/3] Support UDP/IPv4 GSO Jiayu Hu
2018-05-29 7:41 ` [dpdk-dev] [PATCH 1/3] gso: support UDP/IPv4 fragmentation Jiayu Hu
2018-05-29 7:41 ` [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the checksum forwarding engine Jiayu Hu
2018-06-14 14:44 ` Iremonger, Bernard
2018-06-16 9:14 ` Hu, Jiayu [this message]
2018-05-29 7:41 ` [dpdk-dev] [PATCH 3/3] gso: add UDP/IPv4 GSO to the programmer guide Jiayu Hu
2018-06-27 1:59 ` Zhang, Yuwei1
2018-06-17 3:13 ` [dpdk-dev] [PATCH v2 0/3] Support UDP/IPv4 GSO Jiayu Hu
2018-06-17 3:13 ` [dpdk-dev] [PATCH v2 1/3] gso: support UDP/IPv4 fragmentation Jiayu Hu
2018-06-21 8:24 ` Wang, Xiao W
2018-06-21 8:26 ` Hu, Jiayu
2018-06-17 3:13 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: enable UDP GSO in csum engine Jiayu Hu
2018-06-26 9:46 ` Iremonger, Bernard
2018-06-17 3:13 ` [dpdk-dev] [PATCH v2 3/3] gso: update documents for UDP/IPv4 GSO Jiayu Hu
2018-06-22 5:54 ` [dpdk-dev] [PATCH v3 0/3] Support " Jiayu Hu
2018-06-22 5:54 ` [dpdk-dev] [PATCH v3 1/3] gso: support UDP/IPv4 fragmentation Jiayu Hu
2018-06-26 23:58 ` Ophir Munk
2018-06-27 2:28 ` Hu, Jiayu
2018-06-27 5:05 ` Hu, Jiayu
2018-06-22 5:54 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: enable UDP GSO in csum engine Jiayu Hu
2018-06-22 5:54 ` [dpdk-dev] [PATCH v3 3/3] gso: update documents for UDP/IPv4 GSO Jiayu Hu
2018-06-25 4:13 ` [dpdk-dev] [PATCH v3 0/3] Support " Wang, Xiao W
2018-07-06 1:02 ` [dpdk-dev] [PATCH v4 " Jiayu Hu
2018-07-06 1:02 ` [dpdk-dev] [PATCH v4 1/3] gso: support UDP/IPv4 fragmentation Jiayu Hu
2018-07-06 1:02 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: enable UDP GSO in csum engine Jiayu Hu
2018-07-06 1:02 ` [dpdk-dev] [PATCH v4 3/3] gso: update documents for UDP/IPv4 GSO Jiayu Hu
2018-07-11 21:51 ` [dpdk-dev] [PATCH v4 0/3] Support " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED946F0BEFE0A141B63BABBD629A2A9B3890FEB5@shsmsx102.ccr.corp.intel.com \
--to=jiayu.hu@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).