From: "Chi, Xiaobo (Nokia - CN/Hangzhou)" <xiaobo.chi@nokia.com>
To: EXT Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"changchun.ouyang@intel.com" <changchun.ouyang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified
Date: Mon, 9 Nov 2015 10:03:03 +0000 [thread overview]
Message-ID: <EF703E8970265941A1316EEFE0AA7B6C41337176@SGSIMBX004.nsn-intra.net> (raw)
In-Reply-To: <20151109042237.GK2326@yliu-dev.sh.intel.com>
Hi,
For miscdevices, the major device_no is same, so the minor device_no should be set to ditinguish different misc devices; if not set the minor, it may fail while insmod due to the default minor value, 0, has been used by other miscdevice. MISC_DYNAMIC_MINOR means to let Linux kernel dynamically assign one minor devide number while loading.
You can refer to the kni_misc.c
Brgs,
Chi Xiaobo
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of EXT Yuanhan Liu
Sent: Monday, November 09, 2015 12:23 PM
To: Chi, Xiaobo (Nokia - CN/Hangzhou)
Cc: dev@dpdk.org; changchun.ouyang@intel.com
Subject: Re: [dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified
On Fri, Nov 06, 2015 at 02:04:37PM +0800, Xiaobo Chi wrote:
> eventfd_link_misc's minor number shall be MISC_DYNAMIC_MINOR to let Linux kernel dynamically assign one while loading.
For such (fix) patch, I'd like to see what exact issue your patch fixes.
And if it fixes an issue, you'd better title your patch with something
like "vhost: fix ...", so that it's likely Thomas will put it into
high priority.
--yliu
>
> Signed-off-by: Xiaobo Chi <xiaobo.chi@nokia.com>
> ---
> lib/librte_vhost/eventfd_link/eventfd_link.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c b/lib/librte_vhost/eventfd_link/eventfd_link.c
> index c54a938..4b05b5a 100644
> --- a/lib/librte_vhost/eventfd_link/eventfd_link.c
> +++ b/lib/librte_vhost/eventfd_link/eventfd_link.c
> @@ -249,6 +249,7 @@ static const struct file_operations eventfd_link_fops = {
>
>
> static struct miscdevice eventfd_link_misc = {
> + .minor = MISC_DYNAMIC_MINOR,
> .name = "eventfd-link",
> .fops = &eventfd_link_fops,
> };
> --
> 1.9.4.msysgit.2
next prev parent reply other threads:[~2015-11-09 10:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 6:04 Xiaobo Chi
2015-11-09 4:22 ` Yuanhan Liu
2015-11-09 10:03 ` Chi, Xiaobo (Nokia - CN/Hangzhou) [this message]
2015-11-09 10:19 ` Chi, Xiaobo (Nokia - CN/Hangzhou)
2015-11-09 12:58 ` Yuanhan Liu
2015-11-10 2:24 ` Chi, Xiaobo (Nokia - CN/Hangzhou)
2015-11-11 6:57 ` [dpdk-dev] [PATCH v2] vhost: fix eventfd_link.ko insertion failure problem Xiaobo Chi
2015-11-11 7:07 ` Yuanhan Liu
2015-11-24 18:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EF703E8970265941A1316EEFE0AA7B6C41337176@SGSIMBX004.nsn-intra.net \
--to=xiaobo.chi@nokia.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).