DPDK patches and discussions
 help / color / mirror / Atom feed

From: Yongseok Koh <yskoh@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: print Rx/Tx offload values
Date: Wed, 7 Mar 2018 21:36:46 +0000	[thread overview]
Message-ID: <F33A83B5-7AF0-4D44-AC92-BFFD1593EB3D@mellanox.com> (raw)
In-Reply-To: <20180306162822.61791-1-ferruh.yigit@intel.com>


> On Mar 6, 2018, at 8:28 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
> It is not clear which per port offloads are enabled. Printing offloads
> values at forwarding start.
> 
> CRC strip offload value was printed in more verbose manner, it is
> removed since Rx/Tx offload values covers it and printing only CRC one
> can cause confusion.
> 
> Hexadecimal offloads values are not very user friendly but preferred to
> not create to much noise during forwarding start.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Shahaf Shuler <shahafs@mellanox.com>
> ---
> app/test-pmd/config.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 4bb255c62..47845d0cb 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1682,10 +1682,9 @@ rxtx_config_display(void)
> 		struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf;
> 
> 		printf("  port %d:\n", (unsigned int)pid);
> -		printf("  CRC stripping %s\n",
> -				(ports[pid].dev_conf.rxmode.offloads &
> -				 DEV_RX_OFFLOAD_CRC_STRIP) ?
> -				"enabled" : "disabled");
> +		printf("  Rx offloads=0x%"PRIx64" Tx Offloads=0x%"PRIx64"\n",
> +				ports[pid].dev_conf.rxmode.offloads,
> +				ports[pid].dev_conf.txmode.offloads);

So, if someone wants to know what these values mean, they should type
'show port cap all'.

BTW, tx_conf->offloads is printed a few lines later, then isn't it necessary to
print rx_conf->offloads as well? Or, is it supposed to be identical to
dev_conf.rxmode.offloads?

Thanks,
Yongseok

next prev parent reply	other threads:[~2018-03-07 21:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 16:28 Ferruh Yigit
2018-03-07 21:36 ` Yongseok Koh [this message]
2018-03-09 18:27   ` Ferruh Yigit
2018-03-12 14:59 ` Ferruh Yigit
2018-03-12 15:05 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-03-12 17:26   ` Yongseok Koh
2018-03-12 17:46     ` Ferruh Yigit
2018-03-12 17:53   ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2018-03-13  9:24     ` Van Haaren, Harry
2018-03-13 10:21       ` Ferruh Yigit
2018-03-13 11:06         ` Van Haaren, Harry
2018-04-22 23:02     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F33A83B5-7AF0-4D44-AC92-BFFD1593EB3D@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=shahafs@mellanox.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).