From: "Zhang, Helin" <helin.zhang@intel.com>
To: Marc Sune <marc.sune@bisdn.de>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] Adding RTE_KNI_PREEMPT_DEFAULT configuration option
Date: Tue, 17 Feb 2015 01:21:30 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A809527@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1423837525-22283-1-git-send-email-marc.sune@bisdn.de>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marc Sune
> Sent: Friday, February 13, 2015 10:25 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] Adding RTE_KNI_PREEMPT_DEFAULT
> configuration option
>
> This patch introduces CONFIG_RTE_KNI_PREEMPT_DEFAULT flag. When set to
> 'no', KNI kernel thread(s) do not call schedule_timeout_interruptible(), which
> improves overall KNI performance at the expense of CPU cycles (polling).
>
> Default values is 'yes', maintaining the same behaviour as of now.
>
> v2: CONFIG_RTE_KNI_PREEMPT -> CONFIG_RTE_KNI_PREEMPT_DEFAULT
>
> Signed-off-by: Marc Sune <marc.sune@bisdn.de>
Acked-by: Helin Zhang <helin.zhang@intel.com>
> ---
> config/common_linuxapp | 1 +
> lib/librte_eal/linuxapp/kni/kni_misc.c | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/config/common_linuxapp b/config/common_linuxapp index
> d428f84..72ba6ab 100644
> --- a/config/common_linuxapp
> +++ b/config/common_linuxapp
> @@ -359,6 +359,7 @@ CONFIG_RTE_LIBRTE_PIPELINE=y # Compile
> librte_kni # CONFIG_RTE_LIBRTE_KNI=y
> +CONFIG_RTE_KNI_PREEMPT_DEFAULT=y
> CONFIG_RTE_KNI_KO_DEBUG=n
> CONFIG_RTE_KNI_VHOST=n
> CONFIG_RTE_KNI_VHOST_MAX_CACHE_SIZE=1024
> diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c
> b/lib/librte_eal/linuxapp/kni/kni_misc.c
> index 868b325..1935d32 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_misc.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
> @@ -229,9 +229,11 @@ kni_thread_single(void *unused)
> }
> }
> up_read(&kni_list_lock);
> +#ifdef RTE_KNI_PREEMPT_DEFAULT
> /* reschedule out for a while */
> schedule_timeout_interruptible(usecs_to_jiffies( \
> KNI_KTHREAD_RESCHEDULE_INTERVAL));
> +#endif
> }
>
> return 0;
> @@ -252,8 +254,10 @@ kni_thread_multiple(void *param) #endif
> kni_net_poll_resp(dev);
> }
> +#ifdef RTE_KNI_PREEMPT_DEFAULT
> schedule_timeout_interruptible(usecs_to_jiffies( \
> KNI_KTHREAD_RESCHEDULE_INTERVAL));
> +#endif
> }
>
> return 0;
> --
> 2.1.4
next prev parent reply other threads:[~2015-02-17 1:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 14:25 Marc Sune
2015-02-17 1:21 ` Zhang, Helin [this message]
2015-02-23 17:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A809527@SHSMSX104.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=marc.sune@bisdn.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).